Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Redis SSL Support [#556] #611

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Redis SSL Support [#556] #611

merged 5 commits into from
Jun 8, 2022

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Jun 7, 2022 •
edited
Loading

Purpose

Add support for Redis SSL connections to Elasticache.

Changes

Exposes simple config variables to enable Redis SSL connections. Testing isn't included here - I think we can wait until we are hosting an instance of Fidesops that uses Elasticache.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #556

@pattisdr pattisdr marked this pull request as ready for review June 7, 2022 23:37
sanders41
sanders41 reviewed Jun 8, 2022
View reviewed changes
fidesops.toml Show resolved Hide resolved
src/fidesops/core/config.py Show resolved Hide resolved
@sanders41
Copy link
Contributor

@pattisdr I just noticed this still needs to be added to the CHANGELOG

@pattisdr
Copy link
Contributor Author

pattisdr commented Jun 8, 2022

updated, thanks @sanders41

@sanders41 sanders41 merged commit 687a91f into main Jun 8, 2022
@sanders41 sanders41 deleted the fidesops_556_redis_ssl branch June 8, 2022 14:27
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@pattisdr
Redis SSL Support [#556] (#611)
055d2a4 
* Expose simple config variables to enable Redis SSL connections.

* Give SSL_CERT_REQS a default value of required.

* Update changelog.

* Update docs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Redis SSL connections to Elasticache
2 participants
@pattisdr @sanders41