-
Notifications
You must be signed in to change notification settings - Fork 16
353- initial infra for fideslog integration #541
Conversation
Got some feedback from @PSalant726 on this via screenshare code review. Will work on this Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes from today's screen share so I don't forget 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see several of my previous comments have 👍 's or have been resolved, but I'm not seeing any code changes since those comments were left. Maybe you just haven't pushed them up yet - I just wanted to point that out.
@PSalant726 this is ready for another pass! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one of these comments is blocking this right now - the rest are just nits. This is really close 🙏
…of analytics by default
Thanks again for the review @PSalant726 ! Back over to you, with some need for clarification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my comments at this point are just nice-to-haves, nothing blocking. Thanks for sticking with this - it's looking great now 🙌
Ok we're ready again @PSalant726 ! |
* 353- initial infra for fideslog integration * adds changelog * cr and adds storage of analytics id in config * implement internal mode, exclude tests/CI, implement sending server start event * remove validationerr * format * sort * lint * cr changes * lint fixes * Adds root_user to test toml config * Add analytics opt out arg to parser of run_infrastructure * implicit true when passing env var to docker-compose * small code style changes, and updating test fidesops.toml to opt out of analytics by default * missing comma * spacing issue * remove fidesctl dep
NOTICE: Upon merging, internal devs should set a new env var:
FIDESOPS__ROOT_USER__ANALYTICS_ID=internal
Purpose
Adds fideslog integration to fidesops.
Changes
Testing Steps
make server
with no env vars should do 2 things: 1) set aANALYTICS_ID
infidesops.toml
, and 2) send aserver_start
event, viewable in logs:fidesops | INFO:fidesops.analytics:Analytics event sent: server_start with client id: 5905867115b98e73c35a60a35983fbef
make server
with yourANALYTICS_ID
infidesops.toml
. Theserver_start
event should still be sent, and the original ANALYTICS_IDshould exist in
fidesops.toml`make server
withFIDESOPS__ROOT_USER__ANALYTICS_ID
env var set tointernal
should send event with client id ofinternal
, regardless ofANALYTICS_ID
config value.make
commands should not send eventsChecklist
CHANGELOG.md
file in appropriate sectionsRun Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #353