Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Create rate limiter that interacts with Redis #1404

Closed
wants to merge 8 commits into from

Conversation

earmenda
Copy link
Contributor

@earmenda earmenda commented Sep 28, 2022

Purpose

Create a client side rate limiter which can share a state between fidesops instances using Redis.

Changes

  • Create new RateLimiter which can be configured with a period of seconds minutes hours days
  • Implementation for a fixed window limiter that attempts to find an available bucket until timeout is reached

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Good unit test/integration test coverage

Ticket

Fixes #1291

@earmenda earmenda added enhancement New feature or request run unsafe ci checks Triggers running of unsafe CI checks labels Sep 28, 2022
@earmenda earmenda self-assigned this Sep 28, 2022
@earmenda earmenda marked this pull request as ready for review October 3, 2022 17:01
@seanpreston seanpreston closed this Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rate limiter that interacts with Redis
2 participants