Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add due_date to PrivacyRequest model #1259

Merged
merged 11 commits into from
Sep 7, 2022
Merged

Add due_date to PrivacyRequest model #1259

merged 11 commits into from
Sep 7, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Sep 6, 2022 •
edited
Loading

Purpose

Add due_date to PrivacyRequest model. This is setting fideops to implement what's described in #1148.

Changes

  • Add due_date column
  • Set due_date on privacy request creation
  • Add and fix tests to support due_date column

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1147

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review September 6, 2022 19:27
@seanpreston
Copy link
Contributor

Thanks @TheAndrewJackson — this LGTM, I just have a question whether the library is definitely required to make this work, and if strftime won't work just as well.

seanpreston
seanpreston suggested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew, one minor nit

src/fidesops/ops/models/privacy_request.py Outdated Show resolved Hide resolved
tests/ops/models/test_privacy_request.py Outdated Show resolved Hide resolved
@seanpreston seanpreston merged commit 3d7112f into main Sep 7, 2022
@seanpreston seanpreston deleted the 1147_add_due_date_to_privacyrequest branch September 7, 2022 17:01
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@TheAndrewJackson
Add due_date to PrivacyRequest model (#1259)
d7b06af 
* Add `due_date` to `PrivacyRequest` model

* Add `due_date` test and run lints

* Update CHANGELOG.md

* Fix test failures

* Fix type error

* Fix mypy issue

* Switch to `strptime`

* Fix migration down revision

* Move date format string into constant
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

Assignees

@seanpreston seanpreston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add due_date to PrivacyRequest model
2 participants
@TheAndrewJackson @seanpreston