Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a System.vendor_deleted_date property #10

Merged
merged 2 commits into from
May 6, 2024

Conversation

adamsachs
Copy link

@adamsachs adamsachs commented Apr 22, 2024

Potential path for supporting the deletedDate GVL vendor property in our System model

Description Of Changes

Adds a vendor_deleted_date field to the System model which can store a backing vendor record's deletedDate from the GVL, or a comparable property from another vendor record source as needed.

Code Changes

  • adds vendor_deleted_date field to the System model

Steps to Confirm

N/A

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@adamsachs adamsachs self-assigned this Apr 22, 2024
@adamsachs adamsachs changed the title add a System.vendor_deleted_date property add a System.vendor_deleted_date property Apr 22, 2024
@adamsachs adamsachs marked this pull request as ready for review May 6, 2024 12:26
## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.0...main)
## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.1...main)

## [3.0.1](https://github.com/ethyca/fideslang/compare/3.0.0...3.0.1)
Copy link
Author

@adamsachs adamsachs May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will publish a 3.0.1 release on PyPI once this is merged

@adamsachs
Copy link
Author

@pattisdr @NevilleS this is the (very minor) upstream fideslang update that's needed to enable this field being populated through our stack.

this one should be merged first as all the other PRs are dependent upon it 👍

@adamsachs adamsachs merged commit ae88104 into main May 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants