Removing noisy auth log #5920
Merged
Removing noisy auth log #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5920 +/- ##
==========================================
- Coverage 87.00% 86.99% -0.01%
==========================================
Files 416 416
Lines 25524 25522 -2
Branches 2758 2758
==========================================
- Hits 22206 22204 -2
Misses 2718 2718
Partials 600 600 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NevilleS
approved these changes
Mar 23, 2025
src/fides/api/oauth/utils.py
Outdated
| @@ -339,6 +339,14 @@ def has_permissions( | |||
| has_role: bool = _has_scope_via_role( | |||
| token_data=token_data, client=client, endpoint_scopes=endpoint_scopes | |||
| ) | |||
|
|
|||
| if not has_direct_scope and not has_role: | |||
There was a problem hiding this comment.
Nit: I prefer not duplicating the permission check for the log; it's the kind of pattern that invites subtle errors later on. Try this:
Suggested change
| if not has_direct_scope and not has_role: | |
| has_permissions = has_direct_scope or has_role | |
| if not has_permissions: |
src/fides/api/oauth/utils.py
Outdated
| "Authorization failed. Missing required scopes: {}. Neither direct scopes nor role-derived scopes were sufficient.", | ||
| scopes_required, | ||
| ) | ||
|
|
||
| return has_direct_scope or has_role |
There was a problem hiding this comment.
Suggested change
| return has_direct_scope or has_role | |
| return has_permissions |
Co-authored-by: Neville Samuell <neville@ethyca.com>
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 48s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
andres-torres-marroquin
pushed a commit
that referenced
this pull request
Mar 25, 2025
Co-authored-by: Neville Samuell <neville@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LJ-572
Description Of Changes
Removing noisy log
We'll now only log if direct scopes and role-derived scopes are BOTH missing
Steps to Confirm
Auth token missing required scopeslogs should not be present anymore when debug logging is enabled. This was being logged for all endpoints so any endpoint will do to verify this.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works