-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LJ-369 Moved ExecutionLogs into its own file, added tests #5903
Merged
JadeCara
merged 24 commits into
main
from
LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr2
Mar 20, 2025
Merged
LJ-369 Moved ExecutionLogs into its own file, added tests #5903
JadeCara
merged 24 commits into
main
from
LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr2
Mar 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-comments-and-attachments_pr1
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr1 #5903 +/- ##
==========================================================================================================
Coverage 87.02% 87.03%
==========================================================================================================
Files 410 411 +1
Lines 25417 25428 +11
Branches 2749 2749
==========================================================================================================
+ Hits 22120 22131 +11
Misses 2704 2704
Partials 593 593 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-comments-and-attachments_pr1
…nd-attachments_pr1' into LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr2
15 tasks
…-comments-and-attachments_pr1
…nd-attachments_pr1' into LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr2
…-comments-and-attachments_pr1
…nd-attachments_pr1' into LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr2
15 tasks
15 tasks
galvana
approved these changes
Mar 19, 2025
galvana
approved these changes
Mar 19, 2025
Base automatically changed from
LJ-369-be-update-privacy-requests-class-with-comments-and-attachments_pr1
to
main
March 19, 2025 18:33
…-comments-and-attachments_pr2
…-comments-and-attachments_pr2
…-comments-and-attachments_pr2
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 53s |
Commit |
|
Committer | JadeWibbels |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Doing some clean up and adding some unit tests for elements in
src/fides/api/models/privacy_requests.py
. This file has gotten really large so moving this into a directory and breaking out well defined elements into their own files. This will also make adding unit tests less cumbersome.This PR splits out Execution Log specific elements into their own file. I have also added several unit tests for each class/function.
Previous PR:
Consent
,ConsentRequest
LJ-369 Moved Consent/Consent request into their own file, added tests #5900Current PR:
ExecutionLogs
,EXECUTION_CHECKPOINTS
,COMPLETED_EXECUTION_LOG_STATUSES
,EXITED_EXECUTION_LOG_STATUSES
,can_run_checkpoint
Future PRs in the pipeline will further break out:
ProvidedIdentityType
,ProvidedIdentity
LJ-369 Moved Provided Identity into its own file, added tests #5904TraversalDetails
,RequestTask
LJ-369 Moved RequestTask into its own file #5905CallbackType
,SecondPartyRequestFormat
,generate_request_callback_resume_jwe
,generate_request_callback_pre_approval_jwe
,generate_request_task_callback_jwe
LJ-369 Moved CallbackType, SecondPartyRequestFormat to webhook.py #5907Code Changes
src/fides/api/models/privacy_requests/execution_logs.py
and movedExecutionLogs
,EXECUTION_CHECKPOINTS
,COMPLETED_EXECUTION_LOG_STATUSES
,EXITED_EXECUTION_LOG_STATUSES
,can_run_checkpoint
to that file__init__.py
so that existing imports will continue to work.ExecutionLogs
class andcan_run_checkpoint
.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works