Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LJ-507 Support setting publisher country code in Consent Settings #5902

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

erosselli
Copy link
Contributor

@erosselli erosselli commented Mar 18, 2025

Closes LJ-507

Description Of Changes

This adds a new Publisher Settings section under our Settings > Consent page, with a select input for Publisher country. We also make a small backend change to allow sending null values in our PATCH /config endpoint, to allow clearing the publisher country selection.

Code Changes

  • Moved some endpoints / mutations / selectors from privacy-requests.slice.ts to the new file config-settings.slice.ts since they weren't related to privacy requests. For ease of review, this can be seen by looking only at 44976e2
  • Added the new PublisherSettings.tsx component and used it in the consent.tsx page
  • Added cypress tests for the new section

Steps to Confirm

  1. Run fidesplus main with TCF enabled
  2. Go to Settings > Consent in the admin UI. You should see the Publisher country select
  3. Select a country and click "Save". Refresh the page, you should still see your selected country.
  4. Change the country to something else and click "Save". Refresh the page, you should see the new country selected.
  5. Clear the selection and click "Save". Refresh the page, you should see no country selected.

Screen recording

Screen.Recording.2025-03-18.at.4.09.34.PM.mov

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:13pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:13pm

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (aee8f5b) to head (5adb85c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5902      +/-   ##
==========================================
+ Coverage   86.69%   87.01%   +0.31%     
==========================================
  Files         412      412              
  Lines       25451    25451              
  Branches     2750     2750              
==========================================
+ Hits        22066    22147      +81     
+ Misses       2798     2710      -88     
- Partials      587      594       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 BE looks good to me, thanks for taking the time/effort to make the endpoint better!

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the FE 💯 . Tested it and it's working correctly. Code changes look good. Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants