-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LJ-507 Support setting publisher country code in Consent Settings #5902
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5902 +/- ##
==========================================
+ Coverage 86.69% 87.01% +0.31%
==========================================
Files 412 412
Lines 25451 25451
Branches 2750 2750
==========================================
+ Hits 22066 22147 +81
+ Misses 2798 2710 -88
- Partials 587 594 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 BE looks good to me, thanks for taking the time/effort to make the endpoint better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the FE 💯 . Tested it and it's working correctly. Code changes look good. Approved!
Closes LJ-507
Description Of Changes
This adds a new
Publisher Settings
section under ourSettings > Consent
page, with a select input forPublisher country
. We also make a small backend change to allow sending null values in ourPATCH /config
endpoint, to allow clearing the publisher country selection.Code Changes
privacy-requests.slice.ts
to the new fileconfig-settings.slice.ts
since they weren't related to privacy requests. For ease of review, this can be seen by looking only at 44976e2PublisherSettings.tsx
component and used it in theconsent.tsx
pageSteps to Confirm
Publisher country
selectScreen recording
Screen.Recording.2025-03-18.at.4.09.34.PM.mov
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works