Docker layer caching #5882
Docker layer caching #5882
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| @@ -21,7 +21,8 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o | |||
|
|
|||
| ## [Unreleased](https://github.com/ethyca/fides/compare/2.57.0...main) | |||
|
|
|||
|
|
|||
| ### Developer experience | |||
| - Adding Docker layer caching for the backend check's build step [#5882](https://github.com/ethyca/fides/pull/5882) | |||
There was a problem hiding this comment.
nit: let's start nudging our CHANGELOG entries to be more clear. We should be able to write some cursor rules to help with that too 👍.
I think GitLab's thoughts on this are pretty good: https://docs.gitlab.com/development/changelog/#writing-good-changelog-entries
In general I'd say the CHANGELOG should look like: <what was improved> + <how> + <when (if relevant)>
So in your case I'd do this:
| - Adding Docker layer caching for the backend check's build step [#5882](https://github.com/ethyca/fides/pull/5882) | |
| - Improved CI build times for backed checks by adding Docker layer caching to GHA workflow [5882](https://github.com/ethyca/fides/pull/5882) |
| # Install Python Dependencies | ||
|
|
||
| COPY dev-requirements.txt . | ||
| RUN pip install --user -U pip --no-cache-dir -r dev-requirements.txt | ||
|
|
|
|
||
| COPY dev-requirements.txt . | ||
| RUN pip install --user -U pip --no-cache-dir -r dev-requirements.txt | ||
|
|
||
| # Activate a Python venv | ||
| RUN python3 -m venv /opt/fides | ||
| ENV PATH="/opt/fides/bin:${PATH}" | ||
|
|
||
| # Install Python Dependencies | ||
| RUN pip --no-cache-dir --disable-pip-version-check install --upgrade pip setuptools wheel |
There was a problem hiding this comment.
Since we're optimizing, you should be able to include this in the pip install - requirements.txt below too, right?
| - name: Cache Docker layers | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: /tmp/.buildx-cache${{ matrix.python_version == '3.9.18' && '-py39' || '' }} |
There was a problem hiding this comment.
If there are concurrent GHA jobs both running at the same time, is this cache shared between them? In other words, could this lead to strange situations where code from one PR gets into another one?
Or is this caching strictly tied to the particular workflow run
Closes []
Description Of Changes
Write some things here about the changes and any potential caveats
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works