-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opt out all essential. #5850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
gilluminate
requested changes
Mar 6, 2025
I've thoroughly tested these changes and can confirm that the fixes are working as intended. The system now correctly handles:
|
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
gilluminate
approved these changes
Mar 6, 2025
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 50s |
Commit |
|
Committer | Tom Van Dort |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
NevilleS
pushed a commit
that referenced
this pull request
Mar 7, 2025
Co-authored-by: eastandwestwind <eastandwestwind@gmail.com> Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Description Of Changes
Code Changes
TCF Overlay Component Changes:
TCF Purposes Component Changes:
Test Coverage Improvements:
Documentation Updates:
Steps to Confirm
On TCF experience, add some custom notices
In demo page, open up layer 2, opt in to some custom notices and some TCF purposes in the “Purposes” tab
Open up console
Click “save”
Ensure that there are no errors in the console
On TCF experience, add an essential notice
In demo page, click reject all
See that "Essential" notice is "false" in window.Fides, the cookie, and the modal, if you re-open it. It should remain “true” and toggled on.
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works