Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2768 Fix attempt #5295

Draft
wants to merge 2 commits into
base: release-2.43.2
Choose a base branch
from
Draft

PROD-2768 Fix attempt #5295

wants to merge 2 commits into from

Conversation

erosselli
Copy link
Contributor

@erosselli erosselli commented Sep 18, 2024

Description Of Changes

Attempts two different fixes for PROD-2768:

  • User endpoints were using sync sessions but were declared as async; I changed them to be sync since they didn't need any truly async behavior. We know this causes wonky issues, and although we haven't seen this problem manifest with the symptoms described in PROD-2768, we've also updated our FastAPI version in 2.43.1 which could explain why it's showing up differently.
  • 2.43.1 changed some behavior around the CORSMiddleware, we're not sure how this could be causing the issue but since we only see it for PUT/POST requests, we think it could potentially be related. As a temporary workaround (to test the theory that the middleware's the issue), we're skipping getting CORS configs from the DB and pulling them only from env variables, which allows us to skip the somewhat hacky workaround introduced in 2.43.1

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 2:19pm

@erosselli erosselli changed the base branch from release-2.43.1 to release-2.43.2 September 18, 2024 14:19
Copy link

cypress bot commented Sep 18, 2024

fides    Run #9976

Run Properties:  status check passed Passed #9976  •  git commit 77085e8e80 ℹ️: Merge 9d342e6d0d80672310bcef48ad6dc25d5bcbfc39 into 1e9b4a657292c1749711cc22e023...
Project fides
Branch Review refs/pull/5295/merge
Run status status check passed Passed #9976
Run duration 00m 37s
Commit git commit 77085e8e80 ℹ️: Merge 9d342e6d0d80672310bcef48ad6dc25d5bcbfc39 into 1e9b4a657292c1749711cc22e023...
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (3410c42) to head (9d342e6).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.43.2    #5295   +/-   ##
===============================================
  Coverage           86.40%   86.40%           
===============================================
  Files                 362      362           
  Lines               22763    22757    -6     
  Branches             3056     3055    -1     
===============================================
- Hits                19669    19664    -5     
  Misses               2537     2537           
+ Partials              557      556    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pattisdr pattisdr added the do not merge Please don't merge yet, bad things will happen if you do label Sep 18, 2024
@pattisdr
Copy link
Contributor

Reviewed looks good to move forward with testing for an alpha image

@erosselli erosselli marked this pull request as draft September 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Please don't merge yet, bad things will happen if you do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants