Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override ConnectionConfigurationResponse.ts secrets type #5283

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Override ConnectionConfigurationResponse.ts secrets type #5283

merged 3 commits into from
Sep 12, 2024

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Sep 12, 2024 •
edited
Loading

Closes N/A

Description Of Changes

Revert FE type ConnectionConfigurationResponse.ts to be "secrets?: any"

Reverts change made here: fb53995#diff-eb1f9fedd552edc2dc4b27c252498c1a502f37c53ba0e75ebeb8941de58790c0R25

To restore to what was added here: #5227

Code Changes

  • I am making frontend secrets type be any -

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 6:54pm

@pattisdr pattisdr marked this pull request as ready for review September 12, 2024 18:54
@cypress Cypress
Copy link

cypress bot commented Sep 12, 2024 •
edited
Loading

fides    Run #9934

Run Properties:  status check passed Passed #9934  •  git commit 52f0bb655c ℹ️: Merge 4379a2573f9f17c5e39349ea904cad6484959459 into 47934f2610ce30e83d8adc1e67a3...
Project fides
Branch Review refs/pull/5283/merge
Run status status check passed Passed #9934
Run duration 00m 35s
Commit git commit 52f0bb655c ℹ️: Merge 4379a2573f9f17c5e39349ea904cad6484959459 into 47934f2610ce30e83d8adc1e67a3...
Committer Dawn Pattison
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pattisdr pattisdr merged commit 8232497 into main Sep 12, 2024
13 checks passed
@pattisdr pattisdr deleted the revert_frontend_type_secrets branch September 12, 2024 19:30
pattisdr added a commit that referenced this pull request Sep 12, 2024
@pattisdr
Override ConnectionConfigurationResponse.ts secrets type (#5283)
ccfef3a
@cypress Cypress
Copy link

cypress bot commented Sep 12, 2024

fides    Run #9940

Run Properties:  status check passed Passed #9940  •  git commit 82324976d9: Override ConnectionConfigurationResponse.ts secrets type (#5283)
Project fides
Branch Review main
Run status status check passed Passed #9940
Run duration 00m 36s
Commit git commit 82324976d9: Override ConnectionConfigurationResponse.ts secrets type (#5283)
Committer Dawn Pattison
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattisdr @erosselli