Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Yotpo Loyalty with Yotpo Reviews in description #5274

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Replace Yotpo Loyalty with Yotpo Reviews in description #5274

merged 3 commits into from
Sep 10, 2024

Conversation

RobertKeyser
Copy link
Contributor

Closes PROD-2738

Description Of Changes

Yotpo Reviews domain tooltip erroneously refers to Yotpo Loyalty.

Code Changes

  • Edit wording on Yotpo Reviews integration tooltip

Steps to Confirm

  • go to create an integration of type Yotpo Reviews, check all tooltips for references to Yotpo Loyalty.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@RobertKeyser RobertKeyser requested a review from a team as a code owner September 10, 2024 17:21
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 5:25pm

@RobertKeyser RobertKeyser self-assigned this Sep 10, 2024
@RobertKeyser RobertKeyser merged commit 057479b into main Sep 10, 2024
17 checks passed
@RobertKeyser RobertKeyser deleted the rkeyser/fix-yotpo-reviews branch September 10, 2024 17:28
@cypress Cypress
Copy link

cypress bot commented Sep 10, 2024 •
edited
Loading

fides    Run #9870

Run Properties:  status check passed Passed #9870  •  git commit fe4b4cb83a ℹ️: Merge d18e94230ab38805a235d9f3df26c423a0b8453c into 4ce3459323a54fda7fbdba39d4ed...
Project fides
Branch Review refs/pull/5274/merge
Run status status check passed Passed #9870
Run duration 00m 36s
Commit git commit fe4b4cb83a ℹ️: Merge d18e94230ab38805a235d9f3df26c423a0b8453c into 4ce3459323a54fda7fbdba39d4ed...
Committer Robert Keyser
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Sep 10, 2024

fides    Run #9871

Run Properties:  status check passed Passed #9871  •  git commit 057479bb2d: Replace Yotpo Loyalty with Yotpo Reviews in description (#5274)
Project fides
Branch Review main
Run status status check passed Passed #9871
Run duration 00m 36s
Commit git commit 057479bb2d: Replace Yotpo Loyalty with Yotpo Reviews in description (#5274)
Committer Robert Keyser
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees

@RobertKeyser RobertKeyser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertKeyser @galvana