Rename Privacy Notice Properties #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regions" to something that doesn't overlap the fields on the PrivacyNotice schemas in Fidesplus. This way these properties won't automatically be called when trying to serialize a list of Privacy Notices via the API. - Make the new properties more efficient so they can still be used when serializing a single Privacy Notice.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5259/merge
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Dawn Pattison |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
…onfig secrets, and keep privacy notice response configured_regions and systems_applicable to using the aliases -
|
@galvana I regenerated types as a last step and broke something here -- trying to see what went wrong |
…cessarily supply on PrivacyNoticeResponseWithRegions to improve performance.
galvana
approved these changes
Sep 6, 2024
| .group_by(PrivacyExperience.region) | ||
| .order_by(PrivacyExperience.region.asc()) | ||
|
|
||
| # Raw sql for performance |
pattisdr
deleted the
PROD-2708_privacy_notice_performance_improvements
branch
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Dawn Pattison |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #PROD-2708
Description Of Changes
Rename some properties on PrivacyNotice models that have the same name as fields exposed in the API. We want to intentionally choose when these properties are used in the API instead of having them be used automatically. Further, refactor these properties to be slightly more performant when they are called directly.
Code Changes
PrivacyNotice.systems_applicableproperty renamed tocalculated_systems_applicable. Refactored to be slightly more performant, and will typically be used now for serializing a single notice, not multiple notices.PrivacyNotice.configured_regionsproperty renamed toconfigured_regions_for_noticeand refactored to be slightly more performant by using raw sql. This will generally just be used for serializing a single privacy notice - when serializing bulk notices, Plus will typically do the regions calculation separately and share among multiple notices.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works