Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2504 FE When-column-should-never-be-blank-or-have-N-A-in-Activity-table #5177

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Aug 12, 2024

Description Of Changes

Update when column to display when the result appeared and display a tooltip with the full date string.

Code Changes

  • Changed value display in When column from 'source_modified' to 'updated_at'
  • Added tooltip with formatted date when you hover over the relative value

Screenshot

Captura de pantalla 2024-08-12 a la(s) 9 20 26 a  m

Steps to Confirm

  • Setup a D&D Monitor and run it
  • Go to the D&D Activity page
  • Check that the When column displays a recent value (last time it ran and discovered those results)
  • Check that when you hover over the value it displays the full date & time

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 4:38pm

@lucanovera lucanovera changed the title PROD-2504-FE When-column-should-never-be-blank-or-have-N-A-in-Activity-table PROD-2504 FE When-column-should-never-be-blank-or-have-N-A-in-Activity-table Aug 12, 2024
Copy link

cypress bot commented Aug 12, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit d358e93 ℹ️
Started Aug 12, 2024 4:47 PM
Ended Aug 12, 2024 4:48 PM
Duration 00:39 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@lucanovera lucanovera requested a review from jpople August 12, 2024 15:10
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lucanovera lucanovera merged commit fdbbc4a into main Aug 12, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2504-FE-When-column-should-never-be-blank-or-have-N-A-in-Activity-table branch August 12, 2024 18:01
Copy link

cypress bot commented Aug 12, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit fdbbc4a
Started Aug 12, 2024 6:13 PM
Ended Aug 12, 2024 6:13 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants