-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D&D data category picker improvements #5167
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good and tests are passing. Just one minor nitpick comment.
fontWeight={600} | ||
colorScheme="gray" | ||
fontSize="xs" | ||
mr={1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: it's probably slightly preferred to have the gap
on the HStack set to 1 instead of adding a margin here. Seems odd that we're removing default the gap with 0 only to add a margin.
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Closes PROD-2479, PROD-2480
Description Of Changes
Visual and behavioral changes to the data category picker on monitor discovery results.
Old:
New:
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md