Fix password manager auto complete #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Password managers like 1Password were not showing the "create new password" field when users set their password for the first time. 1Password recommends the following. https://developer.1password.com/docs/web/compatible-website-design/#password-change-and-reset-forms More about the autocomplete field here: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
gilluminate
approved these changes
Aug 7, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
I added the
autocompleteattribute to the password input field on the login for so that password managers got the correct hint for whether to show a "new password" form fill or an "existing password" form fill.https://developer.1password.com/docs/web/compatible-website-design/#password-change-and-reset-forms
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
Before:
After:
Code Changes
autocompleteto password input on login page.autocompletefield toCustomTextInputcomponent.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works