Rerun SaaS tests on failure #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
galvana
added
the
run unsafe ci checks
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5137 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 357 357
Lines 22354 22354
Branches 2957 2957
=======================================
Hits 19351 19351
Misses 2480 2480
Partials 523 523 ☔ View full report in Codecov by Sentry. |
gilluminate
approved these changes
Jul 29, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adding the
pytest-rerunfailuresplugin todev-requirements.txt. This plugin introduces a--rerunsflag that allows us to rerun failed tests up tontimes before considering them a failure. We've implemented this to mitigate false positives that frequently occur due to data in the third-party APIs we're integrating with not settling in time for our tests.Code Changes
nox -s "pytest(ops-saas)"command to use--reruns 3Steps to Confirm
External-SaaS-Connectorsbackend check passes in the CI pipelinePre-Merge Checklist
CHANGELOG.md