Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always cookies in preview mode #5131

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jul 26, 2024

Closes PROD-2474

Description Of Changes

If the user's browser is set to ask sites not to track (GPC), we automatically set a cookie and do not display the banner anymore. This is causing an issue in the Admin UI preview mode where the banner preview was disappearing if a user had GPC enabled.

By always clearing cookies in preview mode, we ensure GPC doesn't cause the banner to be removed from the preview.

Code Changes

  • Update preview container ID to be a constant
  • Update preview config to include fidesClearCookie: true

Steps to Confirm

  • Enable GPC in the browser.
  • Visit a non-TCF, Banner and Modal experience in Admin UI
  • If the banner appears, notice that a cookie is set (you can see it set in browser dev tools)
  • Reload the page or navigate away and come back

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 8:02pm

Copy link

cypress bot commented Jul 26, 2024

Passing run #9159 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8f9ca16 into cd35f63...
Project: fides Commit: 5541d217b6 ℹ️
Status: Passed Duration: 00:36 💡
Started: Jul 26, 2024 8:12 PM Ended: Jul 26, 2024 8:12 PM

Review all test suite changes for PR #5131 ↗︎

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

Co-authored-by: jpople <jeremy@ethyca.com>
@gilluminate gilluminate merged commit 7259f7d into main Jul 26, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/PROD-2474_admin-ui-cookie-being-set-in branch July 26, 2024 20:38
Copy link

cypress bot commented Jul 26, 2024

Passing run #9161 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Always cookies in preview mode (#5131)
Project: fides Commit: 7259f7d853
Status: Passed Duration: 00:34 💡
Started: Jul 26, 2024 8:50 PM Ended: Jul 26, 2024 8:51 PM

Review all test suite changes for PR #5131 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants