Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Erasure for Checkr #5121

Merged
merged 14 commits into from
Jul 25, 2024
Merged

Access Erasure for Checkr #5121

merged 14 commits into from
Jul 25, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Jul 22, 2024

Closes #

Description Of Changes

Added files required for the new Checkr integration, access and erasure

Code Changes

  • Added checkr_config.yml, checkr_fixtures.py, checkr_dataset.yml, and test_checkr_task.py

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Ensure the test integration button works
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Pre-Merge Checklist

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 0:14am

Copy link

cypress bot commented Jul 22, 2024

Passing run #9133 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 92b36df into ab17a78...
Project: fides Commit: 81c52a7dd3 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 25, 2024 12:26 AM Ended: Jul 25, 2024 12:27 AM

Review all test suite changes for PR #5121 ↗︎

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (805aa66) to head (6033d8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5121   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files         357      357           
  Lines       22345    22345           
  Branches     2954     2954           
=======================================
  Hits        19339    19339           
  Misses       2482     2482           
  Partials      524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca marked this pull request as ready for review July 23, 2024 20:32
@MarcGEthyca MarcGEthyca requested a review from a team as a code owner July 23, 2024 20:32
@MarcGEthyca MarcGEthyca requested a review from galvana July 23, 2024 20:38
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this integration! Just need a minor fix on the dataset and this is good to go

MarcGEthyca and others added 3 commits July 24, 2024 12:52
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Fixed structure to properly reflect how we are getting this data
@MarcGEthyca MarcGEthyca self-assigned this Jul 24, 2024
@MarcGEthyca MarcGEthyca requested a review from galvana July 24, 2024 18:31
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, this has been the easiest integration to review 🎉

@galvana galvana merged commit 14211e3 into main Jul 25, 2024
14 checks passed
@galvana galvana deleted the fides_ints_309_access_erasure_chechr branch July 25, 2024 00:14
Copy link

cypress bot commented Jul 25, 2024

Passing run #9134 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Access Erasure for Checkr (#5121)
Project: fides Commit: 14211e3084
Status: Passed Duration: 00:38 💡
Started: Jul 25, 2024 12:27 AM Ended: Jul 25, 2024 12:27 AM

Review all test suite changes for PR #5121 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants