Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fides.js sourcemaps during development #5119

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jul 22, 2024

Description Of Changes

Since sourcemaps don't get copied over to privacy center, the easiest solution is to include them in the scripts inline. This is also beneficial when we add GPP where there's potential for more than one sourcemap to be included.

Code Changes

Steps to Confirm

  • From /clients directory in fides, run turbo dev
  • In the browser, load the Privacy Center demo page /fides-js-demo.html
  • Open dev tools to the Source (chrome) or Debugger (firefox) tab
  • Notice that the full source is included for debugging

CleanShot 2024-07-22 at 12 55 14@2x

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 7:23pm

Copy link

cypress bot commented Jul 22, 2024

Passing run #9067 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 637ec92 into 8312146...
Project: fides Commit: d778a96a0b ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 22, 2024 7:34 PM Ended: Jul 22, 2024 7:35 PM

Review all test suite changes for PR #5119 ↗︎

@gilluminate gilluminate merged commit 62e7013 into main Jul 23, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/fidesjs-sourcemaps branch July 23, 2024 00:13
Copy link

cypress bot commented Jul 23, 2024

Passing run #9092 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Include fides.js sourcemaps during development (#5119)
Project: fides Commit: 62e70139b5
Status: Passed Duration: 00:37 💡
Started: Jul 23, 2024 12:24 AM Ended: Jul 23, 2024 12:25 AM

Review all test suite changes for PR #5119 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants