Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to consent experience styling #5085

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Updates to consent experience styling #5085

merged 8 commits into from
Jul 23, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Jul 16, 2024 •
edited by jira bot
Loading

Closes #PROD-2224

Description Of Changes

Styling changes to the GPC badge, GVL badge, and toggle arrows.

Code Changes

  • fides.js css updates to spacing and alignment

Steps to Confirm

  • Verify the badges and arrows are aligned, spaced, and sized properly
  • We will need to verify this will not break any customer's custom CSS

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
Screen.Recording.2024-07-15.at.9.14.30.PM.mov

@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 11:24pm

@cypress Cypress
Copy link

cypress bot commented Jul 16, 2024 •
edited
Loading

Passing run #9089 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 64cb2ee into dd69a98...
Project: fides Commit: 99d781a62f ℹ️
Status: Passed Duration: 00:43 💡
Started: Jul 22, 2024 11:30 PM Ended: Jul 22, 2024 11:31 PM

Review all test suite changes for PR #5085 ↗︎

@Kelsey-Ethyca
Copy link
Contributor Author

Screenshot 2024-07-18 at 10 19 41 PM Screenshot 2024-07-18 at 10 21 18 PM

@Kelsey-Ethyca
Copy link
Contributor Author

Screenshot 2024-07-18 at 10 21 43 PM

@Kelsey-Ethyca
Copy link
Contributor Author

Screenshot 2024-07-22 at 11 59 42 AM

gilluminate
gilluminate approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Happy to see the collapse arrow back to normal. :)

@Kelsey-Ethyca Kelsey-Ethyca merged commit fdd31ca into main Jul 23, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-2224-gpc-styling-issues-on-modal branch July 23, 2024 00:10
@cypress Cypress
Copy link

cypress bot commented Jul 23, 2024

Passing run #9091 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Updates to consent experience styling (#5085)
Project: fides Commit: fdd31ca354
Status: Passed Duration: 00:35 💡
Started: Jul 23, 2024 12:21 AM Ended: Jul 23, 2024 12:22 AM

Review all test suite changes for PR #5085 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelsey-Ethyca @gilluminate