PROD-2349 Fix messaging ui unresponsive. Fix warnings.

[lucanovera]

Description Of Changes

Fix unresponsive messaging ui due to react render loop. Also fix other warnings on the page.

Code Changes

• Fix main loop issue by using useMemo on sortedData
• Fix warning about input without name or id by adding a name property to the toggles
• Fix warning about <p> inside another <p> by adding as="span" to Text
• Added useCallback to useMEssagingTemplateToggle as a best practice

Steps to Confirm

• Log in to admin ui
• Go to Settings > Messaging
• Add a new message or use the toggles and check that the UI still responds

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Issue Requirements are Met
• Update CHANGELOG.md

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Jul 15, 2024 2:23pm

[cypress]

Passing run #8899 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 21022ac into 1957636...
Project: fides	Commit: fe096890a3 ℹ️
Status: Passed	Duration: 00:36 💡
Started: Jul 15, 2024 2:34 PM	Ended: Jul 15, 2024 2:35 PM

Review all test suite changes for PR #5081 ↗︎

[eastandwestwind]

Works great for me, thanks!

[cypress]

Passing run #8900 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

PROD-2349 Fix messaging ui unresponsive. Fix warnings. (#5081)
Project: fides	Commit: e02e6e1b38
Status: Passed	Duration: 00:35 💡
Started: Jul 15, 2024 3:02 PM	Ended: Jul 15, 2024 3:02 PM

Review all test suite changes for PR #5081 ↗︎