Add support for "Key-pair" authentication to Snowflake integration

[andres-torres-marroquin]

Closes #PROD-2140

Description Of Changes

Add support for Key-Pair authentication to the SnowflakeConnector, so it now allows a couple fields to the SnowflakeSchema: private_key and private_key_passphrase.

Code Changes

• Added a couple fields to the SnowflakeSchema: private_key and private_key_passphrase.
• Added some logic to the SQLConnector so now connect_args can be passed down to SQLConnector.create_client through the new SQLConnector.get_connect_args() method.
• Added SnowflakeSchema.get_connect_args() so it now takes the private_key and decrypts it if private_key_passphrase was defined as well.
• Updated tests so they are ran in password mode and private_key mode.

Steps to Confirm

• Add a Snowflake Integration with private_key.

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
  • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated
• If there are any database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Jul 18, 2024 7:29pm

[cypress]

Passing run #9002 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge a154ff5 into 2c99458...
Project: fides	Commit: 1eab4eb436 ℹ️
Status: Passed	Duration: 00:36 💡
Started: Jul 18, 2024 7:40 PM	Ended: Jul 18, 2024 7:41 PM

Review all test suite changes for PR #5079 ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 40.54054% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.43%. Comparing base (51d7b88) to head (65a5741).

Files	Patch %	Lines
...tion_configuration/connection_secrets_snowflake.py	42.85%	9 Missing and 3 partials ⚠️
src/fides/api/service/connectors/sql_connector.py	37.50%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5079      +/-   ##
==========================================
- Coverage   86.51%   86.43%   -0.08%     
==========================================
  Files         357      357              
  Lines       22310    22344      +34     
  Branches     2947     2952       +5     
==========================================
+ Hits        19301    19313      +12     
- Misses       2495     2514      +19     
- Partials      514      517       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adamsachs]

thanks for getting a solid starting approach in place! here's a few initial comments, haven't had a chance to fully review yet.

[adamsachs]

@andres-torres-marroquin generally looking good to me, I'd just like to get the key parsing bit sorted and removed ideally - it feels like it shouldn't be necessary, but maybe there's a nuance there I'm not aware of.

also - have you done any manual testing? we'd like to be extra sure here that this is working as we expect end to end. if you have, pasting some steps and/or screenshots would be helpful - if the screenshots are at all sensitive, feel free to paste it to the jira ticket.

[galvana]

Clever!

[galvana]

@andres-torres-marroquin and I verified both authentication methods from the Admin UI. I just called out the need for error handling around missing passphrases for encrypted private keys but we're following up with that in a separate ticket.

[cypress]

Passing run #9003 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Add support for "Key-pair" authentication to Snowflake integration (#5079)
Project: fides	Commit: 09289b2b3b
Status: Passed	Duration: 00:34 💡
Started: Jul 18, 2024 7:56 PM	Ended: Jul 18, 2024 7:56 PM

Review all test suite changes for PR #5079 ↗︎