Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty Filters modal #5065

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jul 8, 2024

Closes: PROD-2311

Description Of Changes

Memo was not being updated with new table data because it was only monitoring the table instance and not the data. Removing memo since it's really not helping much at all anyway, it's just extracting the data to a variable.

Code Changes

  • Remove memo from the headerGroups variable

Steps to Confirm

  • Log out of Admin UI (important step for reproducing!)
  • Log in and visit Spatial Datamap /datamap
  • Click "Filter" button.
  • Modal should not be empty.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 4:03pm

Copy link

cypress bot commented Jul 8, 2024

Passing run #8791 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ee87ab6 into 890619b...
Project: fides Commit: ba3d773e72 ℹ️
Status: Passed Duration: 00:46 💡
Started: Jul 8, 2024 4:14 PM Ended: Jul 8, 2024 4:15 PM

Review all test suite changes for PR #5065 ↗︎

@Kelsey-Ethyca Kelsey-Ethyca merged commit f5bc35b into main Jul 8, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the gill/datamap-empty-filters-fix branch July 8, 2024 21:16
Kelsey-Ethyca pushed a commit that referenced this pull request Jul 8, 2024
Copy link

cypress bot commented Jul 8, 2024

Passing run #8796 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Fix empty Filters modal (#5065)
Project: fides Commit: f5bc35b1e9
Status: Passed Duration: 00:40 💡
Started: Jul 8, 2024 9:26 PM Ended: Jul 8, 2024 9:27 PM

Review all test suite changes for PR #5065 ↗︎

@cypress cypress bot mentioned this pull request Jul 8, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants