Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Redshift to prefer SSL in generate as well #4849

Merged
merged 2 commits into from
May 3, 2024
Merged

Set Redshift to prefer SSL in generate as well #4849

merged 2 commits into from
May 3, 2024

Conversation

SteveDMurphy
Copy link
Contributor

Closes FIDES-665

Description Of Changes

Code Changes

  • If the connection string is like redshift, sets sslmode to "prefer" instead of "verify-full"

Steps to Confirm

Pre-Merge Checklist

@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 1:58pm

@SteveDMurphy SteveDMurphy force-pushed the SteveDmurphy-fides-665-redshift-ssl branch from bf34b6b to 5dfe069 Compare May 1, 2024 13:58
@cypress Cypress
Copy link

cypress bot commented May 1, 2024

Passing run #7534 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 5dfe069 into c617f68...
Project: fides Commit: c42e942cda ℹ️
Status: Passed Duration: 00:36 💡
Started: May 1, 2024 2:09 PM Ended: May 1, 2024 2:10 PM

Review all test suite changes for PR #4849 ↗︎

@SteveDMurphy SteveDMurphy self-assigned this May 2, 2024
@SteveDMurphy SteveDMurphy marked this pull request as ready for review May 2, 2024 12:40
@SteveDMurphy SteveDMurphy requested a review from NevilleS May 2, 2024 12:41
@SteveDMurphy
Copy link
Contributor Author

@NevilleS targeting you just since you checked out the last one for Redshift as well

NevilleS
NevilleS approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@SteveDMurphy SteveDMurphy merged commit 9c13738 into main May 3, 2024
37 of 40 checks passed
@SteveDMurphy SteveDMurphy deleted the SteveDmurphy-fides-665-redshift-ssl branch May 3, 2024 13:50
@Kelsey-Ethyca Kelsey-Ethyca mentioned this pull request May 3, 2024
Merged
9 tasks
Kelsey-Ethyca pushed a commit that referenced this pull request May 3, 2024
@SteveDMurphy @Kelsey-Ethyca
Set Redshift to prefer SSL in generate as well (#4849)
a5e8ba8
@SteveDMurphy SteveDMurphy mentioned this pull request Jun 20, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees

@SteveDMurphy SteveDMurphy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveDMurphy @NevilleS