Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 204 No Content response #4834

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Apr 26, 2024

Description Of Changes

Allows a SaaS integration request to process HTTP 204 No Content without erroring trying to unwrap the response.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 3:03am

Copy link

cypress bot commented Apr 26, 2024

Passing run #7562 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 1b5bb03 into 8c899c2...
Project: fides Commit: 81a3b0e443 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 2, 2024 3:14 AM Ended: May 2, 2024 3:15 AM

Review all test suite changes for PR #4834 ↗︎

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (8c899c2) to head (1b5bb03).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4834      +/-   ##
==========================================
+ Coverage   86.77%   86.78%   +0.01%     
==========================================
  Files         346      346              
  Lines       20910    20913       +3     
  Branches     2732     2733       +1     
==========================================
+ Hits        18145    18150       +5     
+ Misses       2289     2288       -1     
+ Partials      476      475       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveDMurphy
Copy link
Contributor

Confirmed and tested live tonight as well!

@Kelsey-Ethyca Kelsey-Ethyca merged commit 8165baf into main May 2, 2024
42 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the allow-no-content-response branch May 2, 2024 03:52
Kelsey-Ethyca added a commit that referenced this pull request May 3, 2024
Co-authored-by: Kelsey Thomas <101993653+Kelsey-Ethyca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants