Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fides ints 121 Marigold Engage by Sailthru Access and Erasure #4826

Merged
merged 20 commits into from
May 1, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Apr 24, 2024

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • added required config, dataset, tests, fixtures and in this case overrides

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good

Pre-Merge Checklist

Pre-Merge Checklist

  • Secrets added to 1Password
    • Values for connector_params
    • Any identity values, such as identity_email or identity_phone_number
  • Postman collection
    • All requests in the SaaS config and properly named see mailchimp
    • All requests to create test data
  • Access tests passing
  • Erasure tests passing

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:55pm

@MarcGEthyca MarcGEthyca self-assigned this Apr 24, 2024
Copy link

cypress bot commented Apr 24, 2024

Passing run #7548 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 4331bdd into e273a1d...
Project: fides Commit: e2d2f3dda6 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 1, 2024 9:04 PM Ended: May 1, 2024 9:05 PM

Review all test suite changes for PR #4826 ↗︎

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 51.61290% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (bcebc35) to head (16b19fc).

Files Patch % Lines
...plementations/marigold_engage_request_overrides.py 45.94% 20 Missing ⚠️
src/fides/api/service/connectors/saas_connector.py 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4826       +/-   ##
===========================================
+ Coverage   66.31%   86.77%   +20.46%     
===========================================
  Files         345      346        +1     
  Lines       20855    20909       +54     
  Branches     2727     2732        +5     
===========================================
+ Hits        13829    18144     +4315     
+ Misses       6525     2289     -4236     
+ Partials      501      476       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca marked this pull request as ready for review April 26, 2024 16:25
@MarcGEthyca MarcGEthyca requested a review from a team as a code owner April 26, 2024 16:25
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UAT ✅
Screenshot 2024-05-01 at 1 30 01 PM

@MarcGEthyca MarcGEthyca merged commit 93d3753 into main May 1, 2024
37 of 40 checks passed
@MarcGEthyca MarcGEthyca deleted the new-marigold-engage branch May 1, 2024 21:52
Kelsey-Ethyca pushed a commit that referenced this pull request May 3, 2024
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
@cypress cypress bot mentioned this pull request May 3, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants