Replace h1 with p in consent overlay modal

[SteveDMurphy]

Closes FIDES-247

Description Of Changes

Requested by a user that noticed the h1 element used in the consent overlay modal could detract from SEO.

Found that there is an existing style variable for this (--fides-overlay-font-size-title) that was in some cases being overridden by the h1 element if styled.

Switching to a p allowed the expected style to be used

Code Changes

• Replaced the h1 element with a p element in ConsentContent.tsx

Steps to Confirm

• Tested and validated the change to the consent overlay using the expected variable (graphic below)

With styled h1:

Without styled h1:

After change to a p:

This could potentially result in some change in default appearance for the overlay, which should be reviewed (not a one person choice I think)

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Nov 7, 2023 11:47am

[cypress]

Passing run #5074 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 24cf936 into 5122e33...
Project: fides	Commit: 97ccb4712f ℹ️
Status: Passed	Duration: 00:34 💡
Started: Nov 7, 2023 11:57 AM	Ended: Nov 7, 2023 11:57 AM

Review all test suite changes for PR #4396 ↗︎