Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hardcoded gvl json to latest version #4353

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Oct 27, 2023

Closes n/a

Description Of Changes

We still hardcode the GVL.json (hopefully not for long!), but we need to keep things up to date while we do.

Code Changes

  • update the hardcoded GVL json

Steps to Confirm

  • i guess we should do some basic TCF regression testing just to ensure this doesn't somehow break things!

Pre-Merge Checklist

@adamsachs adamsachs marked this pull request as ready for review October 27, 2023 20:46
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @adamsachs thanks for this last push

I'm right now working on these same non-dynamic tests over in plus!

@cypress
Copy link

cypress bot commented Oct 27, 2023

Passing run #4893 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4831ea2 into 05dfb52...
Project: fides Commit: bd2f424f45 ℹ️
Status: Passed Duration: 00:59 💡
Started: Oct 27, 2023 8:59 PM Ended: Oct 27, 2023 9:00 PM

Review all test suite changes for PR #4353 ↗︎

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05dfb52) 87.72% compared to head (4831ea2) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4353   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files         335      335           
  Lines       21160    21160           
  Branches     2753     2753           
=======================================
  Hits        18563    18563           
  Misses       2127     2127           
  Partials      470      470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsachs adamsachs merged commit 622eb54 into main Oct 27, 2023
@adamsachs adamsachs deleted the asachs/bump-gvl-version branch October 27, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants