Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey monkey connector #2419

Closed
wants to merge 8 commits into from
Closed

Conversation

HamzaWaseem
Copy link
Contributor

Purpose

  • Purpose of this PR is to add Braintree connector access and erasure endpoints

Changes

  • Added config for Surveymonkey Access and Erasure Endpoints
  • Added related dataset and configuration
  • Added associated tests to validate above functionality

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket #1882

Fixes #1882

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +40.69 🎉

Comparison is base (813a7d0) 47.85% compared to head (3206a06) 88.55%.

❗ Current head 3206a06 differs from pull request most recent head eaeb49b. Consider uploading reports for the commit eaeb49b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2419       +/-   ##
===========================================
+ Coverage   47.85%   88.55%   +40.69%     
===========================================
  Files         288      327       +39     
  Lines       16101    15714      -387     
  Branches     2043     4348     +2305     
===========================================
+ Hits         7705    13915     +6210     
+ Misses       8264     1644     -6620     
- Partials      132      155       +23     
Impacted Files Coverage Δ
src/fides/lib/oauth/oauth_util.py 97.36% <0.00%> (-2.64%) ⬇️
src/fides/api/ctl/view.py 27.50% <0.00%> (-1.77%) ⬇️
src/fides/api/ops/db/base.py 100.00% <0.00%> (ø)
src/fides/connectors/models.py 100.00% <0.00%> (ø)
src/fides/lib/models/client.py 100.00% <0.00%> (ø)
src/fides/api/ops/schemas/msg.py 100.00% <0.00%> (ø)
src/fides/lib/models/audit_log.py 100.00% <0.00%> (ø)
src/fides/lib/models/fides_user.py 100.00% <0.00%> (ø)
src/fides/api/ops/schemas/client.py 100.00% <0.00%> (ø)
src/fides/api/ops/schemas/policy.py 100.00% <0.00%> (ø)
... and 305 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Feb 28, 2023

Passing run #507 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7c2ae57 into 813a7d0...
Project: fides Commit: 48a9291387 ℹ️
Status: Passed Duration: 00:55 💡
Started: Feb 28, 2023 7:31 PM Ended: Feb 28, 2023 7:32 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Kelsey-Ethyca Kelsey-Ethyca changed the title 1204 saas connector survey monkey Survey monkey connector Mar 13, 2023
@galvana galvana closed this May 10, 2023
@NevilleS NevilleS deleted the 1204-saas-connector-survey-monkey branch March 14, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey Monkey
2 participants