Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1385 saas connector twilio conversation erasure #1673

Merged
merged 33 commits into from
Nov 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2022

Purpose

  • Purpose of this PR is to add Twilio connector Conversation erasure endpoints

Changes

  • Updated config for Twilio Conversation Erasure Endpoints
  • Updated related dataset and configuration
  • Added override request for Twilio Conversation Erasure Endpoints
  • Update associated tests to validate above functionality

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1385

@ghost ghost requested a review from galvana November 2, 2022 21:29
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor recommendations but otherwise good work! I know a lot of our conventions are just shared through word-of-mouth but this work here is very consistent with the style of the other connectors 👍

@galvana galvana merged commit f18867d into main Nov 17, 2022
@galvana galvana deleted the 1385-saas-connector-twilio-conversation-erasure branch November 17, 2022 21:50
sadaqatullah pushed a commit that referenced this pull request Nov 22, 2022
Co-authored-by: Hamza W <hamza@Hamzas-MacBook-Pro.local>
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twilio (conversation) - erasure
1 participant