-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1385 saas connector twilio conversation erasure #1673
Merged
galvana
merged 33 commits into
main
from
1385-saas-connector-twilio-conversation-erasure
Nov 17, 2022
Merged
1385 saas connector twilio conversation erasure #1673
galvana
merged 33 commits into
main
from
1385-saas-connector-twilio-conversation-erasure
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-connector-twilio-conversation-access
…-connector-twilio-conversation-access
…-connector-twilio-conversation-access
…-connector-twilio-conversation-erasure
ghost
requested a review
from galvana
November 2, 2022 21:29
galvana
reviewed
Nov 11, 2022
galvana
reviewed
Nov 11, 2022
galvana
reviewed
Nov 11, 2022
tests/ops/integration_tests/saas/test_twilio_conversations_task.py
Outdated
Show resolved
Hide resolved
galvana
reviewed
Nov 11, 2022
galvana
reviewed
Nov 11, 2022
galvana
reviewed
Nov 11, 2022
src/fides/api/ops/service/saas_request/override_implementations/twilio_request_overrides.py
Outdated
Show resolved
Hide resolved
galvana
reviewed
Nov 11, 2022
src/fides/api/ops/service/saas_request/override_implementations/twilio_request_overrides.py
Outdated
Show resolved
Hide resolved
galvana
reviewed
Nov 11, 2022
src/fides/api/ops/service/saas_request/override_implementations/twilio_request_overrides.py
Outdated
Show resolved
Hide resolved
galvana
reviewed
Nov 11, 2022
galvana
requested changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor recommendations but otherwise good work! I know a lot of our conventions are just shared through word-of-mouth but this work here is very consistent with the style of the other connectors 👍
…hub.com:ethyca/fides into 1385-saas-connector-twilio-conversation-erasure
galvana
approved these changes
Nov 17, 2022
sadaqatullah
pushed a commit
that referenced
this pull request
Nov 22, 2022
Co-authored-by: Hamza W <hamza@Hamzas-MacBook-Pro.local> Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1385