Move license to root for github detection #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@earmenda i used the license generator in GitHub and it still isn't detecting, I think we just need to merge it to main for this to work. going to go ahead and do so |
NevilleS
reviewed
Oct 7, 2021
ThomasLaPiana
pushed a commit
that referenced
this pull request
Aug 17, 2022
* Log just potentially affected fields on the execution logs, rather than all of the fields. * Add test asserting rules with overlapping data categories don't produce duplicate fields in log. * Update reporting docs to correct an inaccuracy - queries are not logged in the execution logs, we just have the status of the request and potential fields affected. - Also have the examples show the in_processing/complete execution logs instead of pending execution logs, because we don't create pending execution logs for an individual collection anymore. - Privacy requests can also have a "paused" status due to pre-execution policy webhooks * Add missing backticks around collection names.
ThomasLaPiana
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Log just potentially affected fields on the execution logs, rather than all of the fields. * Add test asserting rules with overlapping data categories don't produce duplicate fields in log. * Update reporting docs to correct an inaccuracy - queries are not logged in the execution logs, we just have the status of the request and potential fields affected. - Also have the examples show the in_processing/complete execution logs instead of pending execution logs, because we don't create pending execution logs for an individual collection anymore. - Privacy requests can also have a "paused" status due to pre-execution policy webhooks * Add missing backticks around collection names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
Code Changes
Steps to Confirm
Was not able to confirm other than running licensee to verify our license can be identified correctly:
Pre-Merge Checklist
Description Of Changes