Sync perf -- Run nodes with network=perf to start performance test on multi machines. (draft) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ping-ke
changed the title
This was referenced Oct 24, 2023
This was referenced Nov 7, 2023
qzhodl
reviewed
Nov 16, 2023
| @@ -0,0 +1,180 @@ | |||
| package metrics | |||
There was a problem hiding this comment.
Please keep in mind that we need to add license statement for every new file
| @@ -209,7 +208,14 @@ func (n *EsNode) initStorageManager(ctx context.Context, cfg *Config) error { | |||
| "chunkSize", shardManager.ChunkSize(), | |||
| "kvsPerShard", shardManager.KvEntries()) | |||
|
|
|||
| n.storageManager = ethstorage.NewStorageManager(shardManager, n.l1Source) | |||
| if cfg.Storage.UseMockL1 { | |||
| mockL1 := ethstorage.NewMockL1Source(shardManager, cfg.Storage.L1MockMetaFile) | |||
There was a problem hiding this comment.
It seems that there is a compiling error here
|
Also please note that there is still a Draft flag in the PR title. You may want to remove this flag before requesting code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run nodes with network=perf to start performance test on multi machines:
How to test:
create a storage file
./es-util create --filename storage.dat --chunk_size=131072 --kv_size=131072 --kv_len=4096 --miner=0x5C935469C5592Aeeac3372e922d9bCEabDF8830dfill in the storage file with random data, and create a related meta file for mock l1
./es-util fill_up_shard --filename storage.dat --shard_idx=0 --kv_entries=256 --kv_size 131072 --chunk_size 131072 --metafile storage.dat.metastart nodes with
network=perf, and--l1.mock_metafile storage.dat.metaon the local machine as a sync server to provide blobs.--network perf --p2p.listen.ip 127.0.0.1 --p2p.listen.udp 30303 --p2p.listen.tcp 9222 --p2p.advertise.ip 127.0.0.1 --l1.rpc http://65.108.236.27:8545 --l1.beacon http://65.109.63.154:5052 --storage.files storage.dat --storage.l1contract 0x8FA01287747B8f876C8bA532D9Bd48b73329c431 --storage.miner 0x5C935469C5592Aeeac3372e922d9bCEabDF8830d --storage.kv-size 131072 --storage.chunk-size 131072 --storage.kv-entries 256 --datadir ./database --download.start -3 --log.level debug --l1.mock_metafile storage.dat.metacreate an empty storage file, copy the local metafile to remote machines, and start the node with perf network and l1.mock_metafile as sync client to sync blobs.
note: to test runtime metrics on sync clients or servers, sync client and server can be multiple.
how to verify:
after the test start, log for runtime metrics will print like the following
INFO [10-09|19:34:20.257] runtime metrics "cpu (%)"=55 "memory (MB)"=9198 "disk read (KB)"=69727 "disk write (KB)"=144,879