feat: add checkpoint sync capabilities to nimbus #804
Merged
+83
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk910
reviewed
Oct 10, 2024
pk910
approved these changes
Oct 11, 2024
skylenet
pushed a commit
that referenced
this pull request
Nov 1, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.0](4.3.0...4.4.0) (2024-11-01) ### Features * add checkpoint sync capabilities to nimbus ([#804](#804)) ([853417e](853417e)) * add commit-boost support ([#779](#779)) ([ebbbe83](ebbbe83)) * add docker authentication ([#816](#816)) ([807f6aa](807f6aa)) * add peerdas metrics dashboard ([#790](#790)) ([12b787d](12b787d)) * add rbuilder remove old geth builder - flashbots ([#786](#786)) ([de95c61](de95c61)) * add resource configuration for prometheus and grafana ([#773](#773)) ([d296c26](d296c26)) * add supernode label to every container ([#788](#788)) ([43edfd5](43edfd5)) * add support for fulu/osaka fusaka ([#798](#798)) ([0a9e445](0a9e445)) * add support for remote signers - `use_remote_signer` ([#791](#791)) ([9f1b6e9](9f1b6e9)) * enable one parameter supernode, refactor el,cl,vc ([#778](#778)) ([8513c06](8513c06)) ### Bug Fixes * add database config to assertoor ([#783](#783)) ([56532cf](56532cf)) * add nimbus-eth1 net-key ([#811](#811)) ([c91bbbb](c91bbbb)) * delete unnecessary port assignment for prysm ([#810](#810)) ([47204c3](47204c3)) * docker login to separate action yaml ([#819](#819)) ([2494022](2494022)) * get volume size recommendations when in shadowfork mode ([#820](#820)) ([b1f27c6](b1f27c6)) * mixed up labels ([#799](#799)) ([e2c1528](e2c1528)) * only set supernode if its true ([#796](#796)) ([2110a60](2110a60)) * prefund container suffixes for k8s ([#818](#818)) ([968cfbd](968cfbd)) * remove deprecated http-allow-sync-stalled from LH ([#805](#805)) ([1825dbf](1825dbf)) * Remove not necessary "/api" (and bump verifier version) ([#792](#792)) ([befde97](befde97)) * set default for label-maker ([#797](#797)) ([5b2d234](5b2d234)) * swap http/grpc server ports and replace flags ([#802](#802)) ([8c6df26](8c6df26)) * update built in assertoor tests ([#782](#782)) ([d24fb2a](d24fb2a)) * update nethermind config option ([#824](#824)) ([08ce034](08ce034)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
JulianVentura
added a commit
to lambdaclass/ethereum-package
that referenced
this pull request
Mar 5, 2025
commit 24f8f81750824190c3f3c8df982f8484d80b5752
Merge: 12ca872 03bb449
Author: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
Date: Mon Mar 3 17:30:35 2025 -0300
Merge pull request #5 from ethpandaops/main
chore: `main` fork Syncing to support pectra
commit 03bb449cfd327e55188fb1ff4407c4b75606b911
Author: Rafael Matias <rafael@skyle.net>
Date: Thu Feb 13 12:51:50 2025 +0100
fix: decrease lighthouse mev --prepare-payload-lookahead from 12 to 8s (#904)
As currently used on pectra devnet-6
More context: https://github.com/ethpandaops/pectra-devnets/pull/79
commit 9b3ee49c6086dcbdce833b68d8165f740273f23c
Author: pk910 <github@pk910.de>
Date: Tue Feb 11 21:08:33 2025 +0100
feat: use `eip7805-support` image for dora when eip7805 is scheduled for activation (#900)
commit 2e7212a57bed0bcbcaaa8da432081f693d0bad7c
Author: Rafael Matias <rafael@skyle.net>
Date: Mon Feb 10 14:16:49 2025 +0100
chore(ci): add spellchecker workflow and fix typos (#898)
commit e957062f619b4c8503c2c41cd7f51dbdb48a4ed3
Author: EthPandaOpsBot <113917957+EthPandaOpsBot@users.noreply.github.com>
Date: Mon Feb 10 22:28:54 2025 +1000
chore(main): release 4.5.0 (#897)
:robot: I have created a release *beep* *boop*
---
##
[4.5.0](https://github.com/ethpandaops/ethereum-package/compare/4.4.0...4.5.0)
(2025-02-10)
### ⚠ BREAKING CHANGES
* remove vc_count
([#844](https://github.com/ethpandaops/ethereum-package/issues/844))
### Features
* add custom image for egg
([#859](https://github.com/ethpandaops/ethereum-package/issues/859))
([e60afbe](https://github.com/ethpandaops/ethereum-package/commit/e60afbeb7cefd1ee853c9bdca0041a6d4040fe78))
* add gossip limit as a configuratable flag
([#856](https://github.com/ethpandaops/ethereum-package/issues/856))
([56a3197](https://github.com/ethpandaops/ethereum-package/commit/56a3197f5385de7d8c1e768fe4b537603c86abcf))
* add max,target blobs for future forks
([#851](https://github.com/ethpandaops/ethereum-package/issues/851))
([1c33375](https://github.com/ethpandaops/ethereum-package/commit/1c333758f26ffc17dcfae92db68eda0bd8d2951b))
* add op package per pr check
([#854](https://github.com/ethpandaops/ethereum-package/issues/854))
([0e4e7aa](https://github.com/ethpandaops/ethereum-package/commit/0e4e7aa8da7dc7f4e2270efdc1acded484a31322))
* add spamoor
([#850](https://github.com/ethpandaops/ethereum-package/issues/850))
([a01d772](https://github.com/ethpandaops/ethereum-package/commit/a01d77274ebf7790a610932e225b8415575df492))
* add support for pull through cache
([#833](https://github.com/ethpandaops/ethereum-package/issues/833))
([0b2a2ae](https://github.com/ethpandaops/ethereum-package/commit/0b2a2ae081652f5c7e7ef1da13744a40c7279f37))
* add vero `vc_type`
([#827](https://github.com/ethpandaops/ethereum-package/issues/827))
([c2af143](https://github.com/ethpandaops/ethereum-package/commit/c2af14377ccb118e1ba6b06f1ee8335113ff6e16))
* Add-blockscout_params
([#838](https://github.com/ethpandaops/ethereum-package/issues/838))
([777ec06](https://github.com/ethpandaops/ethereum-package/commit/777ec065efe9714acb2f6762ec21c6f5c1961f4a))
* Adding support for EIP-7732 and EIP-7805
([#880](https://github.com/ethpandaops/ethereum-package/issues/880))
([6b7a409](https://github.com/ethpandaops/ethereum-package/commit/6b7a409f2d78d50dfb66d8de7aededa080ab6230))
* Adding support for new system contracts + updating devnet config
([#862](https://github.com/ethpandaops/ethereum-package/issues/862))
([8ed275a](https://github.com/ethpandaops/ethereum-package/commit/8ed275a4ec4524b1df4b7cfe38a5f2374711760d))
* Replacing mock builder
([#864](https://github.com/ethpandaops/ethereum-package/issues/864))
([d3a0024](https://github.com/ethpandaops/ethereum-package/commit/d3a002494822c23bd7a0b677b738107c262ad0ff))
* support older forks
([#846](https://github.com/ethpandaops/ethereum-package/issues/846))
([d7e31e0](https://github.com/ethpandaops/ethereum-package/commit/d7e31e01ca6fff88c64ee3846d517e2f32d7bbcf))
* update blockscout with new frontend
([#843](https://github.com/ethpandaops/ethereum-package/issues/843))
([4f69962](https://github.com/ethpandaops/ethereum-package/commit/4f69962f440fc85c61e9ec2b812463d9ab965f7a))
* Update devnet-5 example
([#863](https://github.com/ethpandaops/ethereum-package/issues/863))
([04e13f3](https://github.com/ethpandaops/ethereum-package/commit/04e13f3bca8f14207b4b8f6014790c7b1b4affe7))
* Update egg to support new system contract addresses
([#883](https://github.com/ethpandaops/ethereum-package/issues/883))
([9f7ad78](https://github.com/ethpandaops/ethereum-package/commit/9f7ad78bdea16f2da63e0085272b78e55ccdc823))
* use `eip7732-support` image for dora when eip7732 is scheduled for
activation (ePBS)
([#881](https://github.com/ethpandaops/ethereum-package/issues/881))
([dbe7912](https://github.com/ethpandaops/ethereum-package/commit/dbe7912b932261ca3946562c263595e597bc6f8d))
### Bug Fixes
* add fulu overrides automatically for assertoor and dora if fulu is
active
([#858](https://github.com/ethpandaops/ethereum-package/issues/858))
([d6bec16](https://github.com/ethpandaops/ethereum-package/commit/d6bec165b9bbb3e2a63cbafb063fd52197b23af9))
* add txpool to reth api
([#841](https://github.com/ethpandaops/ethereum-package/issues/841))
([35ec958](https://github.com/ethpandaops/ethereum-package/commit/35ec9585a728d373f3e9ec8c84e9abcddfed82a1))
* bump assertoor memory limit to 8G
([#874](https://github.com/ethpandaops/ethereum-package/issues/874))
([8ff3b11](https://github.com/ethpandaops/ethereum-package/commit/8ff3b1138d910cdbff1bc60764e9ddb596c3a551))
* comment out optimism check from per-PR workflow
([#878](https://github.com/ethpandaops/ethereum-package/issues/878))
([02323a3](https://github.com/ethpandaops/ethereum-package/commit/02323a3bf34089117ee303f114ac08267c34f9d0))
* dora override
([#857](https://github.com/ethpandaops/ethereum-package/issues/857))
([50ec581](https://github.com/ethpandaops/ethereum-package/commit/50ec58115674dced97f9159123ba7e2b044518d4))
* Enable txpool on geth,besu and nethermind
([#868](https://github.com/ethpandaops/ethereum-package/issues/868))
([f9d0b50](https://github.com/ethpandaops/ethereum-package/commit/f9d0b501a7a6543149d2ccd9b063f5beb34d30c9))
* Fixes minimal runs with deneb state
([#871](https://github.com/ethpandaops/ethereum-package/issues/871))
([2ca35e8](https://github.com/ethpandaops/ethereum-package/commit/2ca35e8eb74d8a78e5b6fed110d69b0e68308c76))
* mev-builder custom image
([#847](https://github.com/ethpandaops/ethereum-package/issues/847))
([bc89ad3](https://github.com/ethpandaops/ethereum-package/commit/bc89ad316b9b7b137382269138fc37e241a645d1))
* Private key for account 20
([#870](https://github.com/ethpandaops/ethereum-package/issues/870))
([9782552](https://github.com/ethpandaops/ethereum-package/commit/9782552e6828019f07f177c524988c24b4da1e1f))
* **prysm:** run p2p-udp on different port as it might conflict with the
new quic port
([#845](https://github.com/ethpandaops/ethereum-package/issues/845))
([3bb88e0](https://github.com/ethpandaops/ethereum-package/commit/3bb88e04d2fa9f27418c013d656b02a714c20f4d))
* rbuilder upstream repo with reth-rbuilder binary
([#828](https://github.com/ethpandaops/ethereum-package/issues/828))
([55df658](https://github.com/ethpandaops/ethereum-package/commit/55df658f7757d29419aca7510830cf1d5c70d492))
* remove vc_count
([#844](https://github.com/ethpandaops/ethereum-package/issues/844))
([b61a128](https://github.com/ethpandaops/ethereum-package/commit/b61a128bf1d96e8dd11f028925dee9b70e37ac6f))
* replace goomy with spamoor
([#860](https://github.com/ethpandaops/ethereum-package/issues/860))
([28f7b7d](https://github.com/ethpandaops/ethereum-package/commit/28f7b7d4849ceeab56ac648949b74a1aa0e28dee))
* revert egg version
([#852](https://github.com/ethpandaops/ethereum-package/issues/852))
([a182f30](https://github.com/ethpandaops/ethereum-package/commit/a182f3039b91c15cde5b0d0967666d336a9629ac))
* sanity check for count
([#835](https://github.com/ethpandaops/ethereum-package/issues/835))
([2633d15](https://github.com/ethpandaops/ethereum-package/commit/2633d15b9739520bb979887965a04382869d16d8))
* Update default mev-images source
([#884](https://github.com/ethpandaops/ethereum-package/issues/884))
([176b08a](https://github.com/ethpandaops/ethereum-package/commit/176b08a7062a2fe7bd71a141b1e796f040a38dc4))
* Update Erigon docker image repo naming
([#834](https://github.com/ethpandaops/ethereum-package/issues/834))
([ceb1444](https://github.com/ethpandaops/ethereum-package/commit/ceb14448b4e3b48b4cbf893bf5d95572bfd8949c))
* Update ethereum-genesis-generator to fix eip7623 timestamp missing for
Nethermind
([#875](https://github.com/ethpandaops/ethereum-package/issues/875))
([1c1d698](https://github.com/ethpandaops/ethereum-package/commit/1c1d6988f9c1028ec9cdb22655b556977db901b1))
* update kt config
([#876](https://github.com/ethpandaops/ethereum-package/issues/876))
([1704194](https://github.com/ethpandaops/ethereum-package/commit/1704194121ba25e1e845f210f248b9b5993d24c2))
* Update rbuilder flag and add mainnet split example
([#885](https://github.com/ethpandaops/ethereum-package/issues/885))
([4bbd070](https://github.com/ethpandaops/ethereum-package/commit/4bbd0705d80770df230129d43920784b123b6bbd))
* Update test files
([#893](https://github.com/ethpandaops/ethereum-package/issues/893))
([4fcca66](https://github.com/ethpandaops/ethereum-package/commit/4fcca6677bd87b2cb712989bfbcbd1e7bb7152f4))
* use default image for assertoor with electra enabled
([#855](https://github.com/ethpandaops/ethereum-package/issues/855))
([3b51e5e](https://github.com/ethpandaops/ethereum-package/commit/3b51e5e280e9fc1c7dba890c4e8e795a75e525b2))
* use writable path for assertoor db
([#877](https://github.com/ethpandaops/ethereum-package/issues/877))
([a913455](https://github.com/ethpandaops/ethereum-package/commit/a913455bb3cdf9abb5dea8e27def320b5bf3ae75))
### Miscellaneous Chores
* release 4.5.0
([#896](https://github.com/ethpandaops/ethereum-package/issues/896))
([0dc54e0](https://github.com/ethpandaops/ethereum-package/commit/0dc54e0018356e88a478bbaf4c6782cdcb0c9b6f))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
commit 0dc54e0018356e88a478bbaf4c6782cdcb0c9b6f
Author: Rafael Matias <rafael@skyle.net>
Date: Mon Feb 10 13:22:41 2025 +0100
chore: release 4.5.0 (#896)
Release-As: 4.5.0
commit 2c709f18ec0cc58bf4d8d66af363326a2d090201
Author: Rafael Matias <rafael@skyle.net>
Date: Mon Feb 10 11:36:26 2025 +0100
chore: update release please config (#894)
This should prevent major bump when a breaking change is added. We can
still do major releases manually if we want.
commit 1b534d79f589f25cfc0c16c493f06d88d40960cd
Author: Jun Song <87601811+syjn99@users.noreply.github.com>
Date: Mon Feb 10 16:51:09 2025 +0900
chore: remove deprecated flag at `prysm_launcher.star`: `enable-debug-rpc-endpoints` (#882)
```
2025-01-29 16:30:41 time="2025-01-29 07:30:41" level=error msg="enable-debug-rpc-endpoints is deprecated and has no effect. Do not use this flag, it will be deleted soon." prefix=flags
```
https://github.com/prysmaticlabs/prysm/pull/14015 deprecates
`enable-debug-rpc-endpoints`, and by default prysm enables `debug`
endpoints. This PR updates the `prysm_launcher.star` to address this
change.
Co-authored-by: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
commit 4fcca6677bd87b2cb712989bfbcbd1e7bb7152f4
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Mon Feb 10 08:38:50 2025 +0100
fix: Update test files (#893)
commit 4bbd0705d80770df230129d43920784b123b6bbd
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Mon Feb 3 13:33:58 2025 +0100
fix: Update rbuilder flag and add mainnet split example (#885)
commit 176b08a7062a2fe7bd71a141b1e796f040a38dc4
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Sat Feb 1 18:56:20 2025 +0100
fix: Update default mev-images source (#884)
commit 9f7ad78bdea16f2da63e0085272b78e55ccdc823
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Sat Feb 1 18:37:48 2025 +0100
feat: Update egg to support new system contract addresses (#883)
commit dbe7912b932261ca3946562c263595e597bc6f8d
Author: pk910 <github@pk910.de>
Date: Fri Jan 31 15:44:49 2025 +0100
feat: use `eip7732-support` image for dora when eip7732 is scheduled for activation (ePBS) (#881)
uses the `eip7732-support` branch from dora:
https://github.com/ethpandaops/dora/pull/227
commit 6b7a409f2d78d50dfb66d8de7aededa080ab6230
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Mon Jan 27 10:08:50 2025 +0100
feat: Adding support for EIP-7732 and EIP-7805 (#880)
- Awaiting a genesis generator update to consume these values
commit 8ff3b1138d910cdbff1bc60764e9ddb596c3a551
Author: pk910 <github@pk910.de>
Date: Fri Jan 24 22:13:40 2025 +0100
fix: bump assertoor memory limit to 8G (#874)
bump the memory limit for assertoor to 8GB
increasing the limit is necessary to run child processes (like the
execution spec tests) reliable.
the limit is for the whole container, which not only includes assertoor,
but also all sub-processes launched by tests.
commit a913455bb3cdf9abb5dea8e27def320b5bf3ae75
Author: pk910 <github@pk910.de>
Date: Fri Jan 24 22:07:05 2025 +0100
fix: use writable path for assertoor db (#877)
The root folder `/` is not writable when running as non-root user, so we
move the db to the /app folder
commit 02323a3bf34089117ee303f114ac08267c34f9d0
Author: pk910 <github@pk910.de>
Date: Fri Jan 24 20:30:00 2025 +0100
fix: comment out optimism check from per-PR workflow (#878)
commit 1704194121ba25e1e845f210f248b9b5993d24c2
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Thu Jan 16 19:01:49 2025 +0100
fix: update kt config (#876)
commit 1c1d6988f9c1028ec9cdb22655b556977db901b1
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Thu Jan 16 12:46:49 2025 +0100
fix: Update ethereum-genesis-generator to fix eip7623 timestamp missing for Nethermind (#875)
commit bed83c05f847a2591f6212718474ecc78dfbfd95
Author: JihoonSong <jihoonsong@users.noreply.github.com>
Date: Tue Jan 14 17:43:22 2025 +0900
chore: elaborate `snooper_elabed` flag description (#872)
This PR elaborates what the `snooper_elabed` flag does.
commit 2ca35e8eb74d8a78e5b6fed110d69b0e68308c76
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Fri Jan 10 14:47:08 2025 +0100
fix: Fixes minimal runs with deneb state (#871)
commit 9782552e6828019f07f177c524988c24b4da1e1f
Author: Matthew Slipper <me@matthewslipper.com>
Date: Thu Jan 9 10:04:13 2025 -0700
fix: Private key for account 20 (#870)
It was missing a leading 0.
commit f9d0b501a7a6543149d2ccd9b063f5beb34d30c9
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Thu Jan 9 16:41:17 2025 +0100
fix: Enable txpool on geth,besu and nethermind (#868)
commit d3a002494822c23bd7a0b677b738107c262ad0ff
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Tue Jan 7 09:51:50 2025 +0100
feat: Replacing mock builder (#864)
commit 04e13f3bca8f14207b4b8f6014790c7b1b4affe7
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Fri Dec 20 15:11:56 2024 +0700
feat: Update devnet-5 example (#863)
commit 8ed275a4ec4524b1df4b7cfe38a5f2374711760d
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Wed Dec 18 23:33:21 2024 +0700
feat: Adding support for new system contracts + updating devnet config (#862)
Co-authored-by: pk910 <philipp@pk910.de>
Co-authored-by: pk910 <github@pk910.de>
commit 28f7b7d4849ceeab56ac648949b74a1aa0e28dee
Author: pk910 <github@pk910.de>
Date: Wed Dec 18 16:23:36 2024 +0100
fix: replace goomy with spamoor (#860)
This PR replaces [goomy](https://github.com/ethpandaops/goomy-blob) with
[spamoor](https://github.com/ethpandaops/spamoor).
The spamoor project is based on goomy, but was improved a lot to handle
high transaction throughput reliably.
It supports all features that goomy provides, but blob scenarios are
prefixed with `blob-`.
As spamoor works much better by now, it makes sense to deprecate goomy
and replace it with spamoor.
commit e60afbeb7cefd1ee853c9bdca0041a6d4040fe78
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Dec 13 16:22:52 2024 +0100
feat: add custom image for egg (#859)
commit d6bec165b9bbb3e2a63cbafb063fd52197b23af9
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Dec 13 16:05:16 2024 +0100
fix: add fulu overrides automatically for assertoor and dora if fulu is active (#858)
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 50ec58115674dced97f9159123ba7e2b044518d4
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Dec 13 15:33:59 2024 +0100
fix: dora override (#857)
commit 56a3197f5385de7d8c1e768fe4b537603c86abcf
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Thu Dec 12 18:14:44 2024 +0100
feat: add gossip limit as a configuratable flag (#856)
commit 3b51e5e280e9fc1c7dba890c4e8e795a75e525b2
Author: pk910 <github@pk910.de>
Date: Thu Dec 12 13:43:17 2024 +0100
fix: use default image for assertoor with electra enabled (#855)
`electra-support` as been merged into master and a new release is
available too.
commit 1c333758f26ffc17dcfae92db68eda0bd8d2951b
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Wed Dec 11 10:58:39 2024 +0100
feat: add max,target blobs for future forks (#851)
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 0e4e7aa8da7dc7f4e2270efdc1acded484a31322
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Wed Dec 11 10:50:48 2024 +0100
feat: add op package per pr check (#854)
commit a182f3039b91c15cde5b0d0967666d336a9629ac
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Dec 6 17:30:49 2024 +0100
fix: revert egg version (#852)
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit a01d77274ebf7790a610932e225b8415575df492
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Dec 6 16:44:34 2024 +0100
feat: add spamoor (#850)
commit d7e31e01ca6fff88c64ee3846d517e2f32d7bbcf
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Dec 6 15:45:28 2024 +0100
feat: support older forks (#846)
commit 6b7b01920508722703c99f5cac5306d0c95d98e5
Author: Rafael Matias <rafael@skyle.net>
Date: Thu Dec 5 10:33:49 2024 +0100
chore: update release please (#825)
commit 6c901c56e8dc526cd613f5db1ae5cda71f30de25
Author: Rafael Matias <rafael@skyle.net>
Date: Wed Dec 4 21:37:33 2024 +0100
chore(ci): remove docker user as secret (#848)
commit bc89ad316b9b7b137382269138fc37e241a645d1
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Wed Dec 4 15:48:20 2024 +0100
fix: mev-builder custom image (#847)
commit b61a128bf1d96e8dd11f028925dee9b70e37ac6f
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Wed Dec 4 12:42:07 2024 +0100
fix!: remove vc_count (#844)
commit 3bb88e04d2fa9f27418c013d656b02a714c20f4d
Author: Rafael Matias <rafael@skyle.net>
Date: Wed Dec 4 10:45:10 2024 +0100
fix(prysm): run p2p-udp on different port as it might conflict with the new quic port (#845)
Prysm added QUIC to their client as per
https://github.com/prysmaticlabs/prysm/pull/14688 . This currently broke
our runs using the master branch prysm image due to the QUIC port
running on 13000 by default. Which was conflicting with the settings we
were providing for the UDP port:
```sh
--p2p-quic-port value The QUIC port used by libp2p. (default: 13000)
--p2p-tcp-port value The TCP port used by libp2p. (default: 13000)
--p2p-udp-port value The UDP port used by the discovery service discv5. (default: 12000)
```
I've also added the CLI flags for it, but still commented out until a
stable release is done.
commit 4f69962f440fc85c61e9ec2b812463d9ab965f7a
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Tue Dec 3 15:14:55 2024 +0100
feat: update blockscout with new frontend (#843)
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 55df658f7757d29419aca7510830cf1d5c70d492
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Tue Dec 3 15:08:22 2024 +0100
fix: rbuilder upstream repo with reth-rbuilder binary (#828)
Depends on
https://github.com/ethpandaops/eth-client-docker-image-builder/pull/208
Depends on https://github.com/flashbots/rbuilder/pull/237
---------
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 35ec9585a728d373f3e9ec8c84e9abcddfed82a1
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Sat Nov 30 16:37:25 2024 +0100
fix: add txpool to reth api (#841)
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 777ec065efe9714acb2f6762ec21c6f5c1961f4a
Author: ZT <101599447+zt-9@users.noreply.github.com>
Date: Fri Nov 29 08:15:09 2024 -0800
feat: Add-blockscout_params (#838)
fix #837
the default blockscout image version does not work on my machine.
so i added the blockscout_params for blockscout service. now user can
customize the image versions they want to use.
it contains two params:
```yaml
blockscout_params:
# blockscout docker image to use
# Defaults to the latest image
image: "blockscout/blockscout:latest"
# blockscout smart contract verifier image to use
# Defaults to ghcr.io/blockscout/smart-contract-verifier:v1.9.0
verif_image: "ghcr.io/blockscout/smart-contract-verifier:v1.9.0"
```
i already tested it on my machine and it worke well.
---------
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
commit 3ba9e51fd68d740e210e000f37c21ebec71ec58d
Author: Manu NALEPA <nalepae@gmail.com>
Date: Fri Nov 29 16:06:32 2024 +0100
Prysm BN/VC: Fix communication (#839)
This PR has 2 commits:
- Use different ports for gRPC and HTTP communication between Prysm VC
and BN
- Switch gRPC and HTTP ports to be consistent with default values.
Before this PR, we had this issue:
```
docker inspect vc-1-geth-prysm--773bda94114946f3b501f3e293517426
[
{
"Id": "93713c8d7020aeb505836a11a1858e27dd9ecac19e7e7ed4814f677c30bc9c48",
"Created": "2024-11-29T13:05:02.300408215Z",
"Path": "/validator",
"Args": [
"--accept-terms-of-use=true",
"--chain-config-file=/network-configs/config.yaml",
"--suggested-fee-recipient=0x8943545177806ED17B9F23F0a21ee5948eCaa776",
"--disable-monitoring=false",
"--monitoring-host=0.0.0.0",
"--monitoring-port=8080",
"--graffiti=1-geth-prysm",
"--wallet-dir=/validator-keys/prysm",
"--wallet-password-file=/prysm-password/prysm-password.txt",
"--beacon-rpc-provider=172.16.0.13:3500",
"--beacon-rest-api-provider=172.16.0.13:3500",
"--enable-beacon-rest-api"
],
```
```
"--beacon-rpc-provider=172.16.0.13:3500",
"--beacon-rest-api-provider=172.16.0.13:3500",
```
The Prysm VC tried to connect to the Prysm VC with the same port for the
beacon API and the gRPC.
Now, it is:
**VC**:
```
...
"--beacon-rpc-provider=172.16.0.13:4000",
"--beacon-rest-api-provider=http://172.16.0.13:3500"
...
```
BN:
```
...
"--rpc-host=0.0.0.0",
"--rpc-port=4000",
"--http-host=0.0.0.0",
"--http-cors-domain=*",
"--http-port=3500",
...
```
---------
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 0b2a2ae081652f5c7e7ef1da13744a40c7279f37
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Wed Nov 27 12:59:29 2024 +0100
feat: add support for pull through cache (#833)
commit 2633d15b9739520bb979887965a04382869d16d8
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Tue Nov 26 09:37:09 2024 +0100
fix: sanity check for count (#835)
commit ceb14448b4e3b48b4cbf893bf5d95572bfd8949c
Author: Somnath <snb895@outlook.com>
Date: Mon Nov 25 18:47:14 2024 +0400
fix: Update Erigon docker image repo naming (#834)
Rename `thorax` -> `erigontech` for docker hub.
Not changing the `ethpandaops/erigon:main` image which appears to be the
default, changing the pectra version tho. Latest published erigon images
are now multi-arch tho
commit c2af14377ccb118e1ba6b06f1ee8335113ff6e16
Author: Luca | Serenita <70237279+eth2353@users.noreply.github.com>
Date: Wed Nov 20 18:03:47 2024 +0700
feat: add vero `vc_type` (#827)
Adds the Vero validator client as a supported `vc_type`.
The Vero VC doesn't handle keys and requires a remote signer to be used
(`use_remote_signer: true`). It can handle the minimal preset, as well
as custom `seconds_per_slot` values.
I've added the "Vero - Detailed" Grafana dashboard. I'm not sure if it's
a good fit for this repo, let me know if you'd like me to remove it.
---------
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 28717036a27b62b237f9dce70c91560d0cf17665
Author: Rafael Matias <rafael@skyle.net>
Date: Mon Nov 18 17:49:01 2024 +0100
chore: remove kurtosis-tech notice (#831)
commit 861cf2ec532efe6cc2496f53af192826607e7524
Author: EthPandaOpsBot <113917957+EthPandaOpsBot@users.noreply.github.com>
Date: Fri Nov 1 13:50:37 2024 +0100
chore(main): release 4.4.0 (#774)
:robot: I have created a release *beep* *boop*
---
##
[4.4.0](https://github.com/ethpandaops/ethereum-package/compare/4.3.0...4.4.0)
(2024-11-01)
### Features
* add checkpoint sync capabilities to nimbus
([#804](https://github.com/ethpandaops/ethereum-package/issues/804))
([853417e](https://github.com/ethpandaops/ethereum-package/commit/853417efb5a79056bb6e8a1f37739747131066d5))
* add commit-boost support
([#779](https://github.com/ethpandaops/ethereum-package/issues/779))
([ebbbe83](https://github.com/ethpandaops/ethereum-package/commit/ebbbe8365730a79b98e6bf96b72a8f75a9744f1b))
* add docker authentication
([#816](https://github.com/ethpandaops/ethereum-package/issues/816))
([807f6aa](https://github.com/ethpandaops/ethereum-package/commit/807f6aa8a992d1868d2d0aed7f5857df3c5857e5))
* add peerdas metrics dashboard
([#790](https://github.com/ethpandaops/ethereum-package/issues/790))
([12b787d](https://github.com/ethpandaops/ethereum-package/commit/12b787dd7f1b7130dde369c1eb643dedde4ca03c))
* add rbuilder remove old geth builder - flashbots
([#786](https://github.com/ethpandaops/ethereum-package/issues/786))
([de95c61](https://github.com/ethpandaops/ethereum-package/commit/de95c61cf5d2243a3838d2104b5a4591a57e988f))
* add resource configuration for prometheus and grafana
([#773](https://github.com/ethpandaops/ethereum-package/issues/773))
([d296c26](https://github.com/ethpandaops/ethereum-package/commit/d296c265ab7e4e67c9c6774c665fe3b3184f9f13))
* add supernode label to every container
([#788](https://github.com/ethpandaops/ethereum-package/issues/788))
([43edfd5](https://github.com/ethpandaops/ethereum-package/commit/43edfd5a5bb597636dcbaa1d7f299868d27cdab2))
* add support for fulu/osaka fusaka
([#798](https://github.com/ethpandaops/ethereum-package/issues/798))
([0a9e445](https://github.com/ethpandaops/ethereum-package/commit/0a9e445b3cf8a8557bf03b454b0967bf51f6734f))
* add support for remote signers - `use_remote_signer`
([#791](https://github.com/ethpandaops/ethereum-package/issues/791))
([9f1b6e9](https://github.com/ethpandaops/ethereum-package/commit/9f1b6e953fec3fd172543ed8fad510523382c576))
* enable one parameter supernode, refactor el,cl,vc
([#778](https://github.com/ethpandaops/ethereum-package/issues/778))
([8513c06](https://github.com/ethpandaops/ethereum-package/commit/8513c06020812e33a61ecaee073a165d85ed7ce0))
### Bug Fixes
* add database config to assertoor
([#783](https://github.com/ethpandaops/ethereum-package/issues/783))
([56532cf](https://github.com/ethpandaops/ethereum-package/commit/56532cf50fc56e5958b5839905f7f1b1081ad169))
* add nimbus-eth1 net-key
([#811](https://github.com/ethpandaops/ethereum-package/issues/811))
([c91bbbb](https://github.com/ethpandaops/ethereum-package/commit/c91bbbbe20d14712e3731e37bea46a9cf4c88da6))
* delete unnecessary port assignment for prysm
([#810](https://github.com/ethpandaops/ethereum-package/issues/810))
([47204c3](https://github.com/ethpandaops/ethereum-package/commit/47204c350117b2a7b1cfa4c38d3308bd5e90828e))
* docker login to separate action yaml
([#819](https://github.com/ethpandaops/ethereum-package/issues/819))
([2494022](https://github.com/ethpandaops/ethereum-package/commit/2494022122d3590f5dc1ec701a9fb7e081d5c0e6))
* get volume size recommendations when in shadowfork mode
([#820](https://github.com/ethpandaops/ethereum-package/issues/820))
([b1f27c6](https://github.com/ethpandaops/ethereum-package/commit/b1f27c649e61f29700baf9f204b89054e507c44a))
* mixed up labels
([#799](https://github.com/ethpandaops/ethereum-package/issues/799))
([e2c1528](https://github.com/ethpandaops/ethereum-package/commit/e2c1528834809db1f68f79133edc6016132d2f2f))
* only set supernode if its true
([#796](https://github.com/ethpandaops/ethereum-package/issues/796))
([2110a60](https://github.com/ethpandaops/ethereum-package/commit/2110a608205e06e1986c58efeeeefefd37df51eb))
* prefund container suffixes for k8s
([#818](https://github.com/ethpandaops/ethereum-package/issues/818))
([968cfbd](https://github.com/ethpandaops/ethereum-package/commit/968cfbdb702e5e277bec8704e5185055dedabe74))
* remove deprecated http-allow-sync-stalled from LH
([#805](https://github.com/ethpandaops/ethereum-package/issues/805))
([1825dbf](https://github.com/ethpandaops/ethereum-package/commit/1825dbfc6d58a6326f11fa5a9531b6867b0d5b77))
* Remove not necessary "/api" (and bump verifier version)
([#792](https://github.com/ethpandaops/ethereum-package/issues/792))
([befde97](https://github.com/ethpandaops/ethereum-package/commit/befde97ce72f133bd8b491fe2e4a40870af52f12))
* set default for label-maker
([#797](https://github.com/ethpandaops/ethereum-package/issues/797))
([5b2d234](https://github.com/ethpandaops/ethereum-package/commit/5b2d234217de686ac002b077d3047708d0a0a132))
* swap http/grpc server ports and replace flags
([#802](https://github.com/ethpandaops/ethereum-package/issues/802))
([8c6df26](https://github.com/ethpandaops/ethereum-package/commit/8c6df267a4d517e670425e0de4c18cff122500af))
* update built in assertoor tests
([#782](https://github.com/ethpandaops/ethereum-package/issues/782))
([d24fb2a](https://github.com/ethpandaops/ethereum-package/commit/d24fb2a2ec529bb17b386d3c99bcdf9dd2a94118))
* update nethermind config option
([#824](https://github.com/ethpandaops/ethereum-package/issues/824))
([08ce034](https://github.com/ethpandaops/ethereum-package/commit/08ce034e06ecdcc2885e3f5ecf721cf6df6caddd))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
commit de95c61cf5d2243a3838d2104b5a4591a57e988f
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Nov 1 13:32:16 2024 +0100
feat: add rbuilder remove old geth builder - flashbots (#786)
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit cab694a50db684c22decdd28d0787c6e533b82b4
Author: Rafael Matias <rafael@skyle.net>
Date: Fri Nov 1 12:36:44 2024 +0100
chore: run latest kurtosis version again on CI (#823)
commit 08ce034e06ecdcc2885e3f5ecf721cf6df6caddd
Author: Alex <alexb5dh@gmail.com>
Date: Fri Nov 1 13:27:41 2024 +0200
fix: update nethermind config option (#824)
Fixes config file name for Nethermind:
- All *.cfg files were renamed to *.json as part of this PR:
https://github.com/NethermindEth/nethermind/pull/7653
- Skipping file extension will automatically add a proper one
Signed-off-by: Alex <alexb5dh@gmail.com>
commit 968cfbdb702e5e277bec8704e5185055dedabe74
Author: Dan Moore <100106211+rebelArtists@users.noreply.github.com>
Date: Thu Oct 31 14:53:31 2024 +0100
fix: prefund container suffixes for k8s (#818)
**purpose:**
- fix issue when running with k8s backend, where prefunded accts
services are not destroyed instantaneously and this causes 'service
already exists' errors
**tests:**
original error:
```
Running ethereal to derive private keys of key 1
There was an error executing Starlark code
An error occurred executing instruction (number 9) at github.com/rebelArtists/ethereum-package/src/prefunded_accounts/get_prefunded_accounts.star[12:34]:
run_sh(name="run-ethereal-private-key", run="private_key=$(/app/ethereal hd keys --seed=\"code code code code code code code code code code code quality\" --path=\"m/44'/60'/0'/0/1\" | awk '/Private key/{print substr($NF, 3)}'); echo -n $private_key", image="wealdtech/ethereal:latest", description="Running ethereal to derive private keys of key 1")
Caused by: error occurred while creating a run_sh task with image: wealdtech/ethereal:latest
Caused by: Failed registering service with name: 'run-ethereal-private-key'
Caused by: Error registering service 'run-ethereal-private-key'
Caused by: An error occurred creating Kubernetes service in enclave '629c500d8cda49d3b743a3d143d336b7' with ID 'run-ethereal-private-key'
Caused by: Failed to create service 'run-ethereal-private-key' in namespace 'kt-cdk'
Caused by: services "run-ethereal-private-key" already exists
Error encountered running Starlark code.
```
with fix (service name has key number suffix to prevent clash):
```
...
Running ethereal to derive eth address of key 19
Command returned with exit code '0' and the following output: 0x6d5821d6D50108649480A63d6f337F8473d661ef
Running ethereal to derive private keys of key 20
Command returned with exit code '0' and the following output: efa8369dbb93b8b452535ab87f526465e9441c7c5809a942908662b925eaff42
Running ethereal to derive eth address of key 20
Command returned with exit code '0' and the following output: 0x31C916e6EAD0DB63BeD514a6f292C526696F0549
Printing a message
PRE_FUNDED_ACCOUNTS: [struct(address = "0xXYZ", private_key = "ABCDEFG"),...]
```
---------
Co-authored-by: Rafael Matias <rafael@skyle.net>
commit bf0313f72580985dcbcb61bd001622c3a2a0b3d9
Author: Rafael Matias <rafael@skyle.net>
Date: Thu Oct 31 14:47:03 2024 +0100
ci: remove unnecessary docker login (#822)
Causing:
```
Error: Cannot perform an interactive login from a non TTY device
Error: Process completed with exit code 1.
```
commit b1f27c649e61f29700baf9f204b89054e507c44a
Author: Rafael Matias <rafael@skyle.net>
Date: Thu Oct 31 14:37:38 2024 +0100
fix: get volume size recommendations when in shadowfork mode (#820)
config:
```yaml
network_params:
network: "holesky-shadowfork"
persistent: true
```
fixes
```
There was an error interpreting Starlark code
Evaluation error: key "holesky-shadowfork" not in dict
at [github.com/ethpandaops/ethereum-package/main.star:143:55]: run
at [github.com/ethpandaops/ethereum-package/src/participant_network.star:134:48]: launch_participant_network
at [github.com/ethpandaops/ethereum-package/src/el/el_launcher.star:130:35]: launch
at [github.com/ethpandaops/ethereum-package/src/el/geth/geth_launcher.star:59:24]: launch
at [github.com/ethpandaops/ethereum-package/src/el/geth/geth_launcher.star:298:39]: get_config
Error encountered running Starlark code.
```
commit 2494022122d3590f5dc1ec701a9fb7e081d5c0e6
Author: Rafael Matias <rafael@skyle.net>
Date: Thu Oct 31 14:30:43 2024 +0100
fix: docker login to separate action yaml (#819)
- Only run docker login if credentials are available.
- Print rate limits.
commit 53578a6b8b732b5598d0095d7748985836895ff4
Author: Rafael Matias <rafael@skyle.net>
Date: Thu Oct 31 14:21:14 2024 +0100
ci: run previous kurtosis version (#821)
Rolling back to `1.3.1`, until the docker auth problems on `1.4.0` get
fixed https://github.com/kurtosis-tech/kurtosis/pull/2579
commit 807f6aa8a992d1868d2d0aed7f5857df3c5857e5
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Tue Oct 29 15:26:57 2024 +0100
feat: add docker authentication (#816)
Reverts ethpandaops/ethereum-package#701
Depends on https://github.com/kurtosis-tech/kurtosis/pull/2560
commit 07b86746a57bebd0de78c894eddeab4ccd684a45
Author: Matthew Slipper <me@matthewslipper.com>
Date: Sun Oct 27 02:52:13 2024 -0600
chore: Bump ethereum-genesis-generator version (#813)
commit c91bbbbe20d14712e3731e37bea46a9cf4c88da6
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Fri Oct 25 15:28:23 2024 +0200
fix: add nimbus-eth1 net-key (#811)
commit 47204c350117b2a7b1cfa4c38d3308bd5e90828e
Author: Tobias Wohland <TobiWo@users.noreply.github.com>
Date: Thu Oct 24 21:20:53 2024 +0200
fix: delete unnecessary port assignment for prysm (#810)
commit ebbbe8365730a79b98e6bf96b72a8f75a9744f1b
Author: ltitanb <163874448+ltitanb@users.noreply.github.com>
Date: Thu Oct 17 10:22:54 2024 +0100
feat: add commit-boost support (#779)
Initial support for Commit-Boost, adding for now only the PBS module
(equivalent to MEV-Boost).
Note that this depends on [this
PR](https://github.com/Commit-Boost/commit-boost-client/pull/138) being
merged and released.
There is sometimes some ambiguity between mev-boost (go client) and
mev-boost (protocol via the Builder API), so to disambiguate within
commit boost we call the PBS module the sidecar implementing the
mev-boost protocol.
Here I followed the existing convention as much as possible even if it
sounds somewhat repetitive at times (commit-boost-mev-boost).
EDIT: the blocking PR is now merged and released in `0.3.0`
---------
Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
commit 1825dbfc6d58a6326f11fa5a9531b6867b0d5b77
Author: Michael Sproul <micsproul@gmail.com>
Date: Thu Oct 17 12:55:57 2024 +1100
fix: remove deprecated http-allow-sync-stalled from LH (#805)
The `--http-allow-sync-stalled` flag is deprecated as of Lighthouse
v5.3.0, with its behaviour being enabled by default.
In v6.0.0 we would like to remove the flag entirely, which requires
removing it from Kurtosis (which we run on our CI):
- https://github.com/sigp/lighthouse/pull/6490
commit 3735794cb7e4d81e675fbd208bb73f95d58a1bdc
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Oct 16 00:25:28 2024 +0200
chore: prysm - set stable image as default (#793)
commit 0a9e445b3cf8a8557bf03b454b0967bf51f6734f
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Tue Oct 15 17:49:55 2024 +0200
feat: add support for fulu/osaka fusaka (#798)
commit 853417efb5a79056bb6e8a1f37739747131066d5
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Fri Oct 11 13:52:40 2024 +0200
feat: add checkpoint sync capabilities to nimbus (#804)
commit fce1bf02e2a2cce7ab8171cb95d73c7345a6dea3
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Thu Oct 10 10:55:57 2024 +0200
docs: Update issue templates (#803)
commit 8c6df267a4d517e670425e0de4c18cff122500af
Author: Rafael Matias <rafael@skyle.net>
Date: Wed Oct 9 17:49:56 2024 +0200
fix: swap http/grpc server ports and replace flags (#802)
The default image: `gcr.io/prysmaticlabs/prysm/beacon-chain:latest`
already has the `http-` flags as per
https://github.com/prysmaticlabs/prysm/pull/14089
I also swapped the ports. Instead of using 3500 for the HTTP server and
4000 for the RPC server ( which is actually prysm's default behaviour).
The problem is that all the other CL clients are running their HTTP
beacon API under port 4000 ( `BEACON_HTTP_PORT_NUM= 4000`) . So I think
it makes sense to do the same for prysm here.
commit e2c1528834809db1f68f79133edc6016132d2f2f
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Oct 9 15:17:09 2024 +0200
fix: mixed up labels (#799)
commit 5b2d234217de686ac002b077d3047708d0a0a132
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Oct 9 13:02:39 2024 +0200
fix: set default for label-maker (#797)
commit 2110a608205e06e1986c58efeeeefefd37df51eb
Author: Barnabas Busa <barnabas.busa@ethereum.org>
Date: Wed Oct 9 12:49:29 2024 +0200
fix: only set supernode if its true (#796)
commit 9f1b6e953fec3fd172543ed8fad510523382c576
Author: Luca | Serenita <70237279+eth2353@users.noreply.github.com>
Date: Mon Oct 7 15:59:34 2024 +0200
feat: add support for remote signers - `use_remote_signer` (#791)
Adds the `use_remote_signer` flag, outsourcing validator key management
to a remote signer, which validator clients connect to.
Supported by all VCs except Lighthouse through this PR.
Slashing protection DB is not enabled for web3signer since that would
require adding significantly more complexity - creating a separate
postgres DB and running migrations.
I was thinking a lot what to call the remote signer service, in the end
went with `signer-1-geth-lodestar` (this is the remote signer for
`vc-1-geth-lodestar`).
Addresses #263 / #758
Prerequisite for adding [Vero](https://github.com/serenita-org/vero) as
a validator client - it exclusively uses a remote signer
---------
Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
commit 12b787dd7f1b7130dde369c1eb643dedde4ca03c
Author: Katya Ryazantseva <sibkatya@gmail.com>
Date: Mon Oct 7 11:59:03 2024 +0200
feat: add peerdas metrics dashboard (#790)
This PeerDAS metrics dashboard is implemented according to the current
PeerDAS metrics specs. It can be used by all the CL clients which
implemented the set of [these
metrics](https://github.com/ethereum/beacon-metrics/pull/13). The
metrics are still under discussion, so, the dashboard is currently in
development.
Filters: by client, job, supernode.
commit befde97ce72f133bd8b491fe2e4a40870af52f12
Author: D <51912515+adaki2004@users.noreply.github.com>
Date: Mon Oct 7 11:48:33 2024 +0200
Fix: Remove not necessary "/api" (and bump verifier version) (#792)
As per issue in blockscout,
[here](https://github.com/blockscout/blockscout/issues/10869#issuecomment-2395050605)
is the solution which solved the verification problem.
PS: Also bumped the blockscout version itself. (Tested.)
Signed-off-by: D <51912515+adaki2004@users.noreply.github.com>
Co-authored-by: Keszey Dániel <keszeyd@MacBook-Pro.local>
commit 43edfd5a5bb597636dcbaa1d7f299868d27cdab2
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Fri Oct 4 13:20:23 2024 +0200
feat: add supernode label to every container (#788)
commit 4d07aea8e872d98eaceebefab83528335a56aa8c
Author: D <51912515+adaki2004@users.noreply.github.com>
Date: Thu Oct 3 10:43:55 2024 +0200
chore: bump blockscout version (#787)
Currently the 6.7.2 introduced reth support.
Even tho the workaround (below) is still in the code, it fixes some
indexing issue. (Specifically something with the transaction receipts
decoding).
Still active (and if removed, still not working) workaround:
```
"ETHEREUM_JSONRPC_VARIANT": "erigon"
if el_client_name == "erigon" or el_client_name == "reth"
else el_client_name,
```
Co-authored-by: Keszey Dániel <keszeyd@MacBook-Pro.local>
commit 6f9209c72936a5af688239d9835b9d908c9e8fd1
Author: Samuel Laferriere <samlaf92@gmail.com>
Date: Tue Oct 1 14:46:42 2024 -0700
docs: update README grafana example config (#781)
Think the prometheus_grafana services are off by default, since I had to
modify the config this way to get grafana and prometheus to start.
Signed-off-by: Samuel Laferriere <samlaf92@gmail.com>
commit d24fb2a2ec529bb17b386d3c99bcdf9dd2a94118
Author: pk910 <github@pk910.de>
Date: Tue Oct 1 22:02:39 2024 +0200
fix: update built in assertoor tests (#782)
update built in assertoor tests for compatibility with recent assertoor
changes:
* add unique id to all tests
commit 56532cf50fc56e5958b5839905f7f1b1081ad169
Author: pk910 <github@pk910.de>
Date: Tue Oct 1 21:50:13 2024 +0200
fix: add database config to assertoor (#783)
this adds the database section to the assertoor config.
assertoor falls back to an in memory database if the database section is
left out.
however, the in memory database caused issues with dora earlier, so it's
better to use a non persistent file.
commit 8513c06020812e33a61ecaee073a165d85ed7ce0
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Fri Sep 27 14:16:58 2024 +0200
feat: enable one parameter supernode, refactor el,cl,vc (#778)
commit cb87a9a868e89c0f1c82f099a0ad0e448309533b
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Sep 25 15:42:32 2024 +0200
chore: restore besu main branch (#776)
commit d296c265ab7e4e67c9c6774c665fe3b3184f9f13
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Sep 25 14:50:36 2024 +0200
feat: add resource configuration for prometheus and grafana (#773)
Please note:
`grafana_additional_dashboards` ->
`grafana_params.additional_dashboards`
commit ec278db2f3faf625b3eab6d45158e2acc651f8ff
Author: EthPandaOpsBot <113917957+EthPandaOpsBot@users.noreply.github.com>
Date: Mon Sep 23 13:22:19 2024 +0200
chore(main): release 4.3.0 (#749)
:robot: I have created a release *beep* *boop*
---
##
[4.3.0](https://github.com/ethpandaops/ethereum-package/compare/4.2.0...4.3.0)
(2024-09-23)
### Features
* add prefunded accounts
([#752](https://github.com/ethpandaops/ethereum-package/issues/752))
([1be7efa](https://github.com/ethpandaops/ethereum-package/commit/1be7efa028d5b72837a9c4b5de5b70e102e2f166))
* dora - show more infos about all peers on client pages
([#760](https://github.com/ethpandaops/ethereum-package/issues/760))
([c77d95f](https://github.com/ethpandaops/ethereum-package/commit/c77d95fe21deb9dd09481998d2e39f46b148f146))
### Bug Fixes
* `metrics-host-allowlist` for Teku
([#765](https://github.com/ethpandaops/ethereum-package/issues/765))
([ad75fcc](https://github.com/ethpandaops/ethereum-package/commit/ad75fcce4aa3dcd0064a6d538462587e430478a0))
* built in validator lifecycle test for assertoor
([#763](https://github.com/ethpandaops/ethereum-package/issues/763))
([6f868cc](https://github.com/ethpandaops/ethereum-package/commit/6f868ccf26abf341a83bc96569dea0fa890f90f7))
* explicitly set client contexts
([#755](https://github.com/ethpandaops/ethereum-package/issues/755))
([94dc531](https://github.com/ethpandaops/ethereum-package/commit/94dc531e332f4fd4466a9473dfec328a3a681b01))
* no default resource limits
([#768](https://github.com/ethpandaops/ethereum-package/issues/768))
([4c4831b](https://github.com/ethpandaops/ethereum-package/commit/4c4831bc509ae580f68b85c2c5b469d454586def))
* prysm gRPC removal - use http server instead for keymanager
([#761](https://github.com/ethpandaops/ethereum-package/issues/761))
([ba91174](https://github.com/ethpandaops/ethereum-package/commit/ba911745b5e6cdc0216c5394394605d274ce70ef))
* remove epoch checker for goomy
([#754](https://github.com/ethpandaops/ethereum-package/issues/754))
([f124bbf](https://github.com/ethpandaops/ethereum-package/commit/f124bbf96847ec08d3aa7e8b65df336ef6722475))
* remove exp RPC API namespace flag from nimbus-eth1 configuration
([#767](https://github.com/ethpandaops/ethereum-package/issues/767))
([8fec454](https://github.com/ethpandaops/ethereum-package/commit/8fec454f7af0733277336fc3f06376442b7b4fa4))
* reth-builder volume claim
([#771](https://github.com/ethpandaops/ethereum-package/issues/771))
([4570328](https://github.com/ethpandaops/ethereum-package/commit/4570328e47b6ef5a59a47635f6c58acd3f8ad2d1))
* update dora config for latest release & remove custom images
([#748](https://github.com/ethpandaops/ethereum-package/issues/748))
([a433c50](https://github.com/ethpandaops/ethereum-package/commit/a433c50e1c61dd20a6c28dcebfde704c136ddb69))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
commit 4570328e47b6ef5a59a47635f6c58acd3f8ad2d1
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Mon Sep 23 12:58:14 2024 +0200
fix: reth-builder volume claim (#771)
commit 4c4831bc509ae580f68b85c2c5b469d454586def
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Thu Sep 19 15:43:16 2024 +0200
fix: no default resource limits (#768)
commit 8fec454f7af0733277336fc3f06376442b7b4fa4
Author: tersec <tersec@users.noreply.github.com>
Date: Wed Sep 18 07:57:20 2024 +0000
fix: remove exp RPC API namespace flag from nimbus-eth1 configuration (#767)
https://github.com/status-im/nimbus-eth1/pull/2635
commit ad75fcce4aa3dcd0064a6d538462587e430478a0
Author: Dmitrii Shmatko <zilm13@users.noreply.github.com>
Date: Tue Sep 17 01:17:18 2024 +0200
fix: `metrics-host-allowlist` for Teku (#765)
Currently `'*'` is passed to Teku, which is not correct, so I see `Not
Authorized` when trying to access Teku metrics, Prometheus says that
Teku is down because of 403, and Grafana metrics are empty.
Only `*` should be passed, which is the purpose of the fix.
I don't know how to test it, so not 100% on the fix.
commit 6f868ccf26abf341a83bc96569dea0fa890f90f7
Author: pk910 <github@pk910.de>
Date: Thu Sep 12 13:13:57 2024 +0300
fix: built in validator lifecycle test for assertoor (#763)
update the built int validator-lifecycle-test for assertoor
commit ba911745b5e6cdc0216c5394394605d274ce70ef
Author: Rafael Matias <rafael@skyle.net>
Date: Tue Sep 10 12:19:22 2024 +0200
fix: prysm gRPC removal - use http server instead for keymanager (#761)
Related to the deprecation of the gRPC gateway:
https://github.com/prysmaticlabs/prysm/pull/14089
Currently the `mix-with-tools.yaml` test was failing due to the
keymanager being enabled:
```
== FINISHED SERVICE 'vc-2-nethermind-prysm' LOGS ===================================
Caused by: An error occurred while waiting for all TCP and UDP ports to be open
Caused by: Unsuccessful ports check for IP '172.16.0.34' and port spec '{privatePortSpec:0xc00091a0c0}', even after '240' retries with '500' milliseconds in between retries. Timeout '2m0s' has been reached
Caused by: An error occurred while calling network address '172.16.0.34:5056' with port protocol 'TCP' and using time out '200ms'
Caused by: dial tcp 172.16.0.34:5056: connect: connection refused
Error encountered running Starlark code.
```
commit c77d95fe21deb9dd09481998d2e39f46b148f146
Author: Rafael Matias <rafael@skyle.net>
Date: Tue Sep 10 10:19:43 2024 +0200
feat: dora - show more infos about all peers on client pages (#760)
This will enable additional peer infos (ENR/Enode, etc.) to be shown on
the client pages. Implemented in
https://github.com/ethpandaops/dora/pull/117
commit 94dc531e332f4fd4466a9473dfec328a3a681b01
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Thu Aug 29 18:15:19 2024 +0200
fix: explicitly set client contexts (#755)
commit f124bbf96847ec08d3aa7e8b65df336ef6722475
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Aug 28 12:53:41 2024 +0200
fix: remove epoch checker for goomy (#754)
commit 1be7efa028d5b72837a9c4b5de5b70e102e2f166
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Mon Aug 26 15:55:19 2024 +0200
feat: add prefunded accounts (#752)
commit a433c50e1c61dd20a6c28dcebfde704c136ddb69
Author: pk910 <github@pk910.de>
Date: Tue Aug 20 18:32:07 2024 +0200
fix: update dora config for latest release & remove custom images (#748)
commit 2e9e5a41784f792a206f1a108c2c96830b2c95ef
Author: EthPandaOpsBot <113917957+EthPandaOpsBot@users.noreply.github.com>
Date: Mon Aug 19 16:02:53 2024 +0200
chore(main): release 4.2.0 (#709)
:robot: I have created a release *beep* *boop*
---
##
[4.2.0](https://github.com/ethpandaops/ethereum-package/compare/4.1.0...4.2.0)
(2024-08-19)
### Features
* add customizable configuraiton for prometheus retention
([#745](https://github.com/ethpandaops/ethereum-package/issues/745))
([6c02dfe](https://github.com/ethpandaops/ethereum-package/commit/6c02dfee67e239650f9f21786ff5c976770a733b))
* add genesis_gaslimit param configuration
([#726](https://github.com/ethpandaops/ethereum-package/issues/726))
([a4ba9a6](https://github.com/ethpandaops/ethereum-package/commit/a4ba9a65852411db43dbcf3c727c9ad52040e482))
* Add Lighthouse PeerDAS Dashboard
([#736](https://github.com/ethpandaops/ethereum-package/issues/736))
([ffbfde2](https://github.com/ethpandaops/ethereum-package/commit/ffbfde23f2e58350145ab48d0dbce5e245385ab5))
* add peerdas-electra-support
([#740](https://github.com/ethpandaops/ethereum-package/issues/740))
([663e7e6](https://github.com/ethpandaops/ethereum-package/commit/663e7e654b81fb623a1fa486ccf7092ba2e39d80))
* add profiling for prysm
([#722](https://github.com/ethpandaops/ethereum-package/issues/722))
([7dc6660](https://github.com/ethpandaops/ethereum-package/commit/7dc66606f5d5f86d4ef394bc70fe2e936cd55c75))
* add sanity check
([#710](https://github.com/ethpandaops/ethereum-package/issues/710))
([b824cac](https://github.com/ethpandaops/ethereum-package/commit/b824cac89ca2c78604c82544888a89c0c1d3aa80))
* enable dora pprof
([#743](https://github.com/ethpandaops/ethereum-package/issues/743))
([2b7be9a](https://github.com/ethpandaops/ethereum-package/commit/2b7be9a27c516b17322e8028c23813620bfc6afe))
* generate keys if not default key is used
([#707](https://github.com/ethpandaops/ethereum-package/issues/707))
([2d1cab5](https://github.com/ethpandaops/ethereum-package/commit/2d1cab5317dac62524601f392a4a62a7c3a88b80))
* lodestar persists invalid ssz objects by default
([#730](https://github.com/ethpandaops/ethereum-package/issues/730))
([5a45991](https://github.com/ethpandaops/ethereum-package/commit/5a459914327e33c426e82df62af6336970857f08))
* update egg config parameters
([#737](https://github.com/ethpandaops/ethereum-package/issues/737))
([78c2bc7](https://github.com/ethpandaops/ethereum-package/commit/78c2bc77caaf814cf360499b6b61337ea7eb7099))
### Bug Fixes
* add debug ns to nethermind
([#732](https://github.com/ethpandaops/ethereum-package/issues/732))
([372bb52](https://github.com/ethpandaops/ethereum-package/commit/372bb521525948bc0a97a1999e6d233cb2792626))
* allow vc properties in participants_matrix.cl
([#715](https://github.com/ethpandaops/ethereum-package/issues/715))
([c8b9b19](https://github.com/ethpandaops/ethereum-package/commit/c8b9b19c045f6075fa02f9abf8f761a5a8056ba3))
* besu devnet schedule
([#734](https://github.com/ethpandaops/ethereum-package/issues/734))
([28b67cd](https://github.com/ethpandaops/ethereum-package/commit/28b67cd17a6f0abf80c46821465872d4006f9277))
* blobscan redis dependency
([#712](https://github.com/ethpandaops/ethereum-package/issues/712))
([0ed1c9c](https://github.com/ethpandaops/ethereum-package/commit/0ed1c9c8e974f7c6900f68679602d95cfcb17831))
* change churn limit default for pectra tests
([#747](https://github.com/ethpandaops/ethereum-package/issues/747))
([8109054](https://github.com/ethpandaops/ethereum-package/commit/8109054e20121092ad5ad3eebbf1a16a20677887))
* correctly apply extra params if builder is enabled
([#725](https://github.com/ethpandaops/ethereum-package/issues/725))
([a94caf0](https://github.com/ethpandaops/ethereum-package/commit/a94caf02c327347a7e6b4ed2f99badb787a25dc7))
* disable all assertoor tests by default
([#738](https://github.com/ethpandaops/ethereum-package/issues/738))
([2961f96](https://github.com/ethpandaops/ethereum-package/commit/2961f969402b3f3dbf6f584e74644cf32cfd7902))
* lodestar vc faster startup
([#721](https://github.com/ethpandaops/ethereum-package/issues/721))
([225e3d8](https://github.com/ethpandaops/ethereum-package/commit/225e3d80fe0389f6a22c88a56075ad86a1ae2b00))
* readme eof
([#739](https://github.com/ethpandaops/ethereum-package/issues/739))
([7f94f6e](https://github.com/ethpandaops/ethereum-package/commit/7f94f6e2fefe21e11edb7cf5dc827e3f486afe98))
* remove custom peerdas images for dora & assertoor
([#741](https://github.com/ethpandaops/ethereum-package/issues/741))
([a19398d](https://github.com/ethpandaops/ethereum-package/commit/a19398decc892ba6749284495891184de987cab0))
* remove subscribe all subnet nimbus
([#719](https://github.com/ethpandaops/ethereum-package/issues/719))
([ef92f8f](https://github.com/ethpandaops/ethereum-package/commit/ef92f8f45e4e32d0e2b9711ca9671ff5d1bcab00))
* remove subscribe-all-subnets from default prysm config
([#717](https://github.com/ethpandaops/ethereum-package/issues/717))
([6348c0b](https://github.com/ethpandaops/ethereum-package/commit/6348c0b4c0b8a03a27cdf8a5fa8615b0ab323d7b))
* remove subscribe-all-subnets lighthouse/lodestar/teku
([#720](https://github.com/ethpandaops/ethereum-package/issues/720))
([cdb20e1](https://github.com/ethpandaops/ethereum-package/commit/cdb20e18110e3c85817adc7e970d4b4cbd445feb))
* update snapshots URL
([#731](https://github.com/ethpandaops/ethereum-package/issues/731))
([f9269ad](https://github.com/ethpandaops/ethereum-package/commit/f9269ad7e7bc04fae486b340f8d189d3b965f4b2))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
commit 6c02dfee67e239650f9f21786ff5c976770a733b
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Mon Aug 19 15:53:06 2024 +0200
feat: add customizable configuraiton for prometheus retention (#745)
commit 8109054e20121092ad5ad3eebbf1a16a20677887
Author: Parithosh Jayanthi <parithosh.jayanthi@ethereum.org>
Date: Mon Aug 19 15:00:35 2024 +0200
fix: change churn limit default for pectra tests (#747)
commit 3c168c3c02f6776abeee3f52d2b3f047e3e74d39
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Thu Aug 15 22:50:16 2024 +0200
chore: update tracoor image, and peerdas fork version defaults (#742)
commit 2b7be9a27c516b17322e8028c23813620bfc6afe
Author: pk910 <github@pk910.de>
Date: Thu Aug 15 18:04:30 2024 +0200
feat: enable dora pprof (#743)
helps debugging dora issues
commit 663e7e654b81fb623a1fa486ccf7092ba2e39d80
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Thu Aug 15 14:54:45 2024 +0200
feat: add peerdas-electra-support (#740)
commit a19398decc892ba6749284495891184de987cab0
Author: pk910 <github@pk910.de>
Date: Thu Aug 15 14:48:06 2024 +0200
fix: remove custom peerdas images for dora & assertoor (#741)
commit 7f94f6e2fefe21e11edb7cf5dc827e3f486afe98
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Aug 14 09:40:31 2024 +0200
fix: readme eof (#739)
commit 2961f969402b3f3dbf6f584e74644cf32cfd7902
Author: pk910 <github@pk910.de>
Date: Tue Aug 13 14:47:59 2024 +0200
fix: disable all assertoor tests by default (#738)
disable all assertoor tests by default to prevent accidentally running
tests twice
commit 78c2bc77caaf814cf360499b6b61337ea7eb7099
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Tue Aug 13 13:07:35 2024 +0200
feat: update egg config parameters (#737)
commit ffbfde23f2e58350145ab48d0dbce5e245385ab5
Author: Katya Ryazantseva <sibkatya@gmail.com>
Date: Tue Aug 13 11:25:39 2024 +0300
feat: Add Lighthouse PeerDAS Dashboard (#736)
Grafana dashboard for monitoring Lighthouse PeerDAS metrics.
<img width="883" alt="Screenshot 2024-08-10 at 19 04 13"
src="https://github.com/user-attachments/assets/53a1f05f-ad5a-49ad-8879-edaa816f8072">
commit 225e3d80fe0389f6a22c88a56075ad86a1ae2b00
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Fri Aug 9 14:40:52 2024 +0200
fix: lodestar vc faster startup (#721)
Signed-off-by: Barnabas Busa <busa.barnabas@gmail.com>
commit b2e2b51db7b5b4fff5be2ce5deca6eb3fd665e5c
Author: Pablo Castellano <pablo@anche.no>
Date: Fri Aug 9 11:47:15 2024 +0200
chore: Update blobscan docker images (#735)
These new images are much more optimized and are ten times lighter
(https://github.com/Blobscan/blobscan/pull/390)
commit 372bb521525948bc0a97a1999e6d233cb2792626
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Tue Aug 6 16:32:57 2024 +0200
fix: add debug ns to nethermind (#732)
commit f9269ad7e7bc04fae486b340f8d189d3b965f4b2
Author: Rafael Matias <rafael@skyle.net>
Date: Tue Aug 6 16:08:56 2024 +0200
fix: update snapshots URL (#731)
commit 5a459914327e33c426e82df62af6336970857f08
Author: Nico Flaig <nflaig@protonmail.com>
Date: Tue Aug 6 15:00:23 2024 +0100
feat: lodestar persists invalid ssz objects by default (#730)
Would be good to have invalid ssz objects persisted by default in case
there is a consensus bug or other issue. There is not much downside to
this besides slight storage increase but since states / blocks are
generally small on devnets this shouldn't matter, also we prune objects
after some time (15 days).
commit 28b67cd17a6f0abf80c46821465872d4006f9277
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Tue Aug 6 15:49:00 2024 +0200
fix: besu devnet schedule (#734)
commit 0ed1c9c8e974f7c6900f68679602d95cfcb17831
Author: Barnabas Busa <busa.barnabas@gmail.com>
Date: Wed Jul 31 12:26:52 2024 +0200
fix: blobscan redis dependency (#712)
commit a4ba9a65852411db43dbcf3c727c9ad52040e482
Author: Ji Hwan KIM <125336262+jhkimqd@users.noreply.github.com>
Date: Mon Jul 29 19:57:15 2024 +0900
feat: add genesis_gaslimit param configuration (#726)
This PR adds `genesis_gas_limit` parameter within `network_params.yaml`
to make the parameter configurable using Kurtosis.
It seems like
[ethereum-genesis-generator](https://github.com/ethpandaops/ethereum-genesis-generator),
which is being used in this package already has the capability to change
`genesis_gas_limit` by changing `export
GENESIS_GASLIMIT="${GENESIS_GASLIMIT:-30000000}"` within
[defaults.env](https://github.com/ethpandaops/ethereum-genesis-generator/blob/master/defaults/defaults.env#L27).
This feature didn't seem like it was directly transferred to the
`ehtereum-package`.
Tested locally with the `main` branch and changing the
`genesis_gas_limit` value to `50000000`.
---------
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
commit a94caf02c327347a7e6b4ed2f99badb787a25dc7
Author: Nico Flaig <nflaig@protonmail.com>
Date: Mon Jul 29 11:30:50 2024 +0100
fi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.