Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default config #632

Merged
merged 2 commits into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/tests/mix-assert.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ participants:
cl_type: lighthouse
- el_type: reth
cl_type: lodestar
- el_type: nimbus
- el_type: geth # temp remove nimbus-eth1 till they fix their bugs
cl_type: grandine
additional_services:
- assertoor
Expand Down
1 change: 1 addition & 0 deletions .github/tests/mix-with-tools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ participants:
cl_type: teku
- el_type: nethermind
cl_type: prysm
cl_image: ethpandaops/prysm-beacon-chain:webfix
- el_type: erigon
cl_type: nimbus
- el_type: besu
Expand Down
12 changes: 7 additions & 5 deletions src/package_io/input_parser.star
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def input_parser(plan, input_args):


def parse_network_params(plan, input_args):
result = default_input_args()
result = default_input_args(input_args)
if input_args.get("network_params", {}).get("preset") == "minimal":
result["network_params"] = default_minimal_network_params()

Expand All @@ -397,8 +397,6 @@ def parse_network_params(plan, input_args):
if "vc" in input_args["participants_matrix"]:
vc_matrix = input_args["participants_matrix"]["vc"]

participants = []

for el in el_matrix:
for cl in cl_matrix:
participant = {k: v for k, v in el.items()}
Expand Down Expand Up @@ -708,9 +706,13 @@ def get_client_node_selectors(participant_node_selectors, global_node_selectors)
return node_selectors


def default_input_args():
def default_input_args(input_args):
network_params = default_network_params()
participants = []
if "participants_matrix" not in input_args:
participants = [default_participant()]
else:
participants = []

participants_matrix = []
return {
"participants": participants,
Expand Down