-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flashbots #130
feat: flashbots #130
Conversation
I've addressed issue #124 in this PR, but not other 2. And I've refactored BundlingService with the issue #125 in mind, so it should be easier to implement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, I notice that the bundler makes a loss everytime we use flashbots. Can you please investigate what is the issue? We have to address that first.
@ch4r10t33r Looked into it. It's not related to Flashbots and this is the same issue that we're having on Polygon (ticket PRO-2045) We're losing money when a bundle's gas price is equal to a userop's gas price. |
Description
Tested on Sepolia
https://sepolia.etherscan.io/tx/0xcf1589b7e80e0d6f22b13e8aa6425c61c90bf127ec34b5bf02fa85766809627f
There's some weird issue on Sepolia.
https://relay-sepolia.flashbots.net
is always returning "internal server error" even if a bundle is successfully submitted (I've reported it to devs on Discord)Tested on Goerli:
https://goerli.etherscan.io/tx/0xab98000a3f9bade11eeb4fffb4c05ba8784da9c39b3136d97319943e4dc18669
https://goerli.etherscan.io/tx/0xf89d34b8147798856dae5e449f5c517d41fde642df975784c60a00df5d995f4c
https://goerli.etherscan.io/tx/0xbb95249afa472327bcdbdfe297c8a669cf55e317fb203c84b0eee7166c332c15
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyFurther comments (optional)