Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flashbots #130

Merged
merged 8 commits into from
Dec 8, 2023
Merged

feat: flashbots #130

merged 8 commits into from
Dec 8, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Dec 6, 2023

Description

  • feat: submission of bundles via Flashbots Builders
  • refactored Bundling Service
  • feat: configurable size & interval of bundling
  • feat: timeout for flashbots submission (5 minutes?)
  • fix: better handling of failed userops

Tested on Sepolia
https://sepolia.etherscan.io/tx/0xcf1589b7e80e0d6f22b13e8aa6425c61c90bf127ec34b5bf02fa85766809627f
There's some weird issue on Sepolia. https://relay-sepolia.flashbots.net is always returning "internal server error" even if a bundle is successfully submitted (I've reported it to devs on Discord)

Tested on Goerli:
https://goerli.etherscan.io/tx/0xab98000a3f9bade11eeb4fffb4c05ba8784da9c39b3136d97319943e4dc18669
https://goerli.etherscan.io/tx/0xf89d34b8147798856dae5e449f5c517d41fde642df975784c60a00df5d995f4c
https://goerli.etherscan.io/tx/0xbb95249afa472327bcdbdfe297c8a669cf55e317fb203c84b0eee7166c332c15

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride changed the title wip: flashbots feat: flashbots Dec 7, 2023
@0xSulpiride
Copy link
Member Author

0xSulpiride commented Dec 7, 2023

I've addressed issue #124 in this PR, but not other 2. And I've refactored BundlingService with the issue #125 in mind, so it should be easier to implement.
@ch4r10t33r

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I notice that the bundler makes a loss everytime we use flashbots. Can you please investigate what is the issue? We have to address that first.

@0xSulpiride
Copy link
Member Author

@ch4r10t33r Looked into it. It's not related to Flashbots and this is the same issue that we're having on Polygon (ticket PRO-2045) We're losing money when a bundle's gas price is equal to a userop's gas price.
I will address it in a separate PR since it's not related to Flashbots and we have a separate ticket for this issue.

@0xSulpiride 0xSulpiride merged commit 6bb7c8c into master Dec 8, 2023
4 of 5 checks passed
@0xSulpiride 0xSulpiride deleted the flashbots branch December 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants