Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature_Fix #47

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Signature_Fix #47

merged 2 commits into from
Nov 28, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added validatorAddress to signatures so that the validation works on walletConnect test app for deployed wallets only

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Screenshot 2024-11-27 at 12 13 38 PM

@vignesha22 vignesha22 merged commit 899473e into master Nov 28, 2024
3 of 4 checks passed
@vignesha22 vignesha22 deleted the Signature_Fix_SmartWallet branch November 28, 2024 13:12
@vignesha22 vignesha22 restored the Signature_Fix_SmartWallet branch December 3, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@kanthgithub kanthgithub Awaiting requested review from kanthgithub

@nikhilkumar1612 nikhilkumar1612 Awaiting requested review from nikhilkumar1612

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vignesha22 @ch4r10t33r @0xSulpiride