fix: PRO-2630 Delete sessionKey fix - ContentType in APIDelete Request #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yooo! You forgot to bump the version in package.json! |
ch4r10t33r
approved these changes
Aug 22, 2024
0xSulpiride
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete sessionKey fix - ContentType in APIDelete Request
Description
Bug
SessionSDK fails to delete session-key
Error: Body cannot be empty when content-type is set to 'application/json'
at SessionKeyValidator.deleteSessionKey (/home/bacancy/e2e-sdk-modular/etherspot-modular-sdk/dist/sdk/SessionKeyValidator/SessionKeyValidator.js:319:19)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async SessionKeyValidator.disableSessionKey (/home/bacancy/e2e-sdk-modular/etherspot-modular-sdk/dist/sdk/SessionKeyValidator/SessionKeyValidator.js:137:17)
at async file:///home/bacancy/e2e-sdk-modular/test/specs/testnet/sessionkey/userOpsSessionkey.spec.js:405:32
at async run (file:///home/bacancy/e2e-sdk-modular/test/utils/baseTest.js:8:9)
Fix:
content-type is not needed for deleteSessionKey as all request data is being sent as queryparams
Types of changes