-
Notifications
You must be signed in to change notification settings - Fork 111
DB Store Abstractions #993
Conversation
// But it is also returned with additional data from get function call | ||
// and as the argument in iterator function definition. | ||
type IndexItem struct { | ||
Address []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add a bool field to control if Index
encode/decode should actually fetch data from mock globalstore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @janos
There's a few comments in the body of the PR. one thing that I particularly don't really understand is that UseMockStore
bool pointer. does this somehow relate to the current (on master
) db layout with the mockStore
component injection (which is in fact just a store
). In general I would like to avoid using field names that include mock
(s) in production code.
thanks <3 🙏
|
@justelad This field was left by my mistake after an attempt to have a mock store integration in shed. We decided that it may be better to leave this integration for localstore or a higher level package. I will remove this field. |
@justelad I missed this comment while writing responses here is a brief explanation #993 (comment). |
address @justelad and @nonsense then we can submit to upstream |
Submitted upstream ethereum/go-ethereum#18183. |
This PR introduces a small package with database abstractions that may be used for swarm storage layer. Closes: #989.
This PR is not required to be merged into the master branch until there is an implementation that depends on it.
This PR is open for reviews and suggestions on design and new features. It is founded on requirements described in https://hackmd.io/ffBjSu8RTyKikvRO7bYrzA#.
Future generalization: #1001.