This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
cmd/swarm: add cli UI for tag progress on pushsync #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
tag-cli-ui
branch
2 times, most recently
from
6eac88e to
c044c9d
Compare
|
lint fails on travis https://travis-ci.org/ethersphere/swarm/jobs/589438833#L491 |
acud
force-pushed
the
tag-cli-ui
branch
2 times, most recently
from
e00b2bd to
b872629
Compare
acud
force-pushed
the
tag-cli-ui
branch
2 times, most recently
from
8d471b6 to
a30e735
Compare
api, cmd: fixes after rebase master cmd/swarm: make progressbars show up by default change for loop cmd/swarm: add chunk count to progress bars cmd/swarm: fix tests with new flag cmd/swarm: remove number of chunks cmd/swarm: add debug mode for progress bars
nonsense
approved these changes
Sep 30, 2019
nonsense
reviewed
Sep 30, 2019
zelig
approved these changes
Sep 30, 2019
nonsense
reviewed
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some progress bars that are shown on the console when uploading files with the
--trackoption.We should also consider that right now there is no distinction between pushsync uploads and pullsync uploads, so if a user does not have pushsync enabled and uploads with this flag, the CLI will hang indefinitely because the associated tag is not updated.
We should consider integrating tags into pull syncing as well.