Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Fix goroutine leak by closing accounts manager on Node.Stop #1147

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,14 @@ func (n *Node) Start() error {
return err
}

if n.accman == nil {
var err error
n.accman, n.ephemeralKeystore, err = makeAccountManager(n.config)
if err != nil {
return err
}
}

// Initialize the p2p server. This creates the node key and
// discovery databases.
n.serverConfig = n.config.P2P
Expand Down Expand Up @@ -435,6 +443,13 @@ func (n *Node) Stop() error {
// unblock n.Wait
close(n.stop)

if n.accman != nil {
if err := n.accman.Close(); err != nil {
return err
}
n.accman = nil
}

// Remove the keystore if it was created ephemerally.
var keystoreErr error
if n.ephemeralKeystore != "" {
Expand Down