Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: code signing #137

Merged
merged 1 commit into from
Jun 28, 2022
Merged

feat: code signing #137

merged 1 commit into from
Jun 28, 2022

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Jun 23, 2022 •
edited
Loading

This adds support for Code Signing for macOS and Windows. We need to setup though following secrets:

  • MACOS_CERT_P12 - macOS signing certificate
  • MACOS_CERT_PASSWORD - password for the macOS certificate
  • WINDOWS_CODESIGN_P12 - Windows signing certificate
  • WINDOWS_CODESIGN_PASSWORD - password for the Windows certificate

Moreover the Apple Developer Identity

Closes #3

@AuHau AuHau mentioned this pull request Jun 27, 2022
Merged
@AuHau AuHau force-pushed the feat/code-signing branch from ecf2bbe to 4fc2737 Compare June 28, 2022 12:13
@AuHau AuHau marked this pull request as ready for review June 28, 2022 12:13
vojtechsimetka
vojtechsimetka approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@vojtechsimetka vojtechsimetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Do you need me to setup the secrets?

@AuHau
Copy link
Contributor Author

AuHau commented Jun 28, 2022

Lgtm. Do you need me to setup the secrets?

Already done

@AuHau AuHau merged commit 7e5feca into master Jun 28, 2022
@AuHau AuHau deleted the feat/code-signing branch June 28, 2022 12:22
@bee-worker bee-worker mentioned this pull request Jun 28, 2022
Closed
@bee-worker bee-worker mentioned this pull request Jul 5, 2022
Merged
@AuHau AuHau mentioned this pull request Jul 6, 2022
Merged
This was referenced Jul 6, 2022
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@bee-worker bee-worker mentioned this pull request Sep 15, 2022
Merged
@bee-worker bee-worker mentioned this pull request Dec 21, 2022
Merged
@bee-worker bee-worker mentioned this pull request Jan 19, 2023
Merged
@bee-worker bee-worker mentioned this pull request Apr 13, 2023
Merged
This was referenced Apr 27, 2023
Merged
Merged
@bee-worker bee-worker mentioned this pull request May 18, 2023
Merged
@bee-worker bee-worker mentioned this pull request May 25, 2023
Merged
This was referenced Aug 11, 2023
Merged
Merged
Merged
@bee-worker bee-worker mentioned this pull request Aug 31, 2023
Merged
@bee-worker bee-worker mentioned this pull request Sep 25, 2023
Merged
@bee-worker bee-worker mentioned this pull request Oct 18, 2023
Merged
This was referenced Dec 6, 2023
Merged
Merged
Merged
Merged
Merged
@bee-worker bee-worker mentioned this pull request Mar 26, 2024
Merged
This was referenced Jun 3, 2024
Merged
Merged
Merged
Merged
Merged
@bee-worker bee-worker mentioned this pull request Jun 11, 2024
Merged
This was referenced Jul 25, 2024
Merged
Merged
@bee-worker bee-worker mentioned this pull request Oct 25, 2024
Merged
@bee-worker bee-worker mentioned this pull request Nov 11, 2024
Merged
This was referenced Nov 25, 2024
Merged
Merged
@bee-worker bee-worker mentioned this pull request Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechsimetka vojtechsimetka vojtechsimetka approved these changes

@agazso agazso agazso approved these changes

@Cafe137 Cafe137 Awaiting requested review from Cafe137 Cafe137 is a code owner

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code signing
3 participants
@AuHau @agazso @vojtechsimetka