Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code signing #137

Merged
merged 1 commit into from
Jun 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/tools/add-macos-cert.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/usr/bin/env sh

KEY_CHAIN=build.keychain
MACOS_CERT_P12_FILE=certificate.p12

# Recreate the certificate from the secure environment variable
echo $MACOS_CERT_P12 | base64 --decode > $MACOS_CERT_P12_FILE

#create a keychain
security create-keychain -p actions $KEY_CHAIN

# Make the keychain the default so identities are found
security default-keychain -s $KEY_CHAIN

# Unlock the keychain
security unlock-keychain -p actions $KEY_CHAIN

security import $MACOS_CERT_P12_FILE -k $KEY_CHAIN -P $MACOS_CERT_PASSWORD -T /usr/bin/codesign;

security set-key-partition-list -S apple-tool:,apple: -s -k actions $KEY_CHAIN

# remove certs
rm -fr *.p12
20 changes: 20 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,22 @@ jobs:
- name: Install dependencies
run: npm ci && cd ./installer && npm ci

- name: Set MacOS signing certs
if: matrix.os == 'macos-latest'
run: .github/tools/add-macos-cert.sh
env:
MACOS_CERT_P12: ${{ secrets.MACOS_CERT_P12 }}
MACOS_CERT_PASSWORD: ${{ secrets.MACOS_CERT_PASSWORD }}

- name: Set Windows signing certificate
if: matrix.os == 'windows-latest'
continue-on-error: true
id: write_file
uses: timheuer/base64-to-file@v1
with:
fileName: 'win-certificate.pfx'
encodedString: ${{ secrets.WINDOWS_CODESIGN_P12 }}

- name: Configure secrets
uses: jossef/action-set-json-field@v1
with:
Expand All @@ -30,7 +46,11 @@ jobs:

- name: Publish
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
WINDOWS_CODESIGN_FILE: ${{ steps.write_file.outputs.filePath }}
WINDOWS_CODESIGN_PASSWORD: ${{ secrets.WINDOWS_CODESIGN_PASSWORD }}
run: npm run publish

- name: Create Sentry release
Expand Down
39 changes: 39 additions & 0 deletions forge.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
const path = require('path')
const fs = require('fs')

// Taken over from https://github.com/electron/fiddle/blob/main/forge.config.js

if (process.env['WINDOWS_CODESIGN_FILE']) {
const certPath = path.join(__dirname, 'win-certificate.pfx')
const certExists = fs.existsSync(certPath)

if (certExists) {
process.env['WINDOWS_CODESIGN_FILE'] = certPath
}
}

const iconPath = path.resolve(__dirname, 'assets', 'icon.icns')

const config = {
Expand All @@ -15,10 +25,12 @@ const config = {
OriginalFilename: 'Swarm Desktop',
},
osxSign: {
identity: '3rd Party Mac Developer Application: Swarm Association (9J9SPHU9RP)',
hardenedRuntime: true,
'gatekeeper-assess': false,
entitlements: 'assets/entitlements.plist',
'entitlements-inherit': 'assets/entitlements.plist',
'signature-flags': 'library',
},
},
electronInstallerDebian: {
Expand All @@ -29,6 +41,8 @@ const config = {
name: '@electron-forge/maker-squirrel',
config: {
name: 'swarm-desktop',
certificateFile: process.env['WINDOWS_CODESIGN_FILE'],
certificatePassword: process.env['WINDOWS_CODESIGN_PASSWORD'],
},
},
{
Expand Down Expand Up @@ -62,4 +76,29 @@ const config = {
],
}

function notarizeMaybe() {
if (process.platform !== 'darwin') {
return
}

if (!process.env.CI) {
console.log(`Not in CI, skipping notarization`)
return
}

if (!process.env.APPLE_ID || !process.env.APPLE_ID_PASSWORD) {
console.warn('Should be notarizing, but environment variables APPLE_ID or APPLE_ID_PASSWORD are missing!')
return
}

config.packagerConfig.osxNotarize = {
appBundleId: 'org.ethswarm.swarmDesktop',
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_ID_PASSWORD,
ascProvider: '9J9SPHU9RP',
}
}

notarizeMaybe()

module.exports = config