generic (smart contract) event listener #921
Conversation
zelig
changed the title
zelig
force-pushed
the
postage-listener
branch
2 times, most recently
from
3aae8ad to
0112f43
Compare
| // using an event channel, we subscribe to filter logs emmitted by the postage contract(s) | ||
| // since the last block recorded that had a relevant event | ||
| events := make(chan types.Log) | ||
| sub, err := lis.client.SubscribeFilterLogs(ctx, query(from, lis.addrs...), events) |
There was a problem hiding this comment.
Note that this means dropping support for http and https rpc connections as the underlying eth_subscribe call is only avail on ws and ipc. (which should not be an issue, our integration tests use geth and can be switched over easily. infura also supports wss endpoints).
There was a problem hiding this comment.
otherwise we cannot do subscription since there is no push notiffications, so what to do?
| // using an event channel, we subscribe to filter logs emmitted by the postage contract(s) | ||
| // since the last block recorded that had a relevant event | ||
| events := make(chan types.Log) | ||
| sub, err := lis.client.SubscribeFilterLogs(ctx, query(from, lis.addrs...), events) |
There was a problem hiding this comment.
The fromBlock used to be ignored in the past (see ethereum/go-ethereum#15063). Not sure if this was fixed, will have to check this.
There was a problem hiding this comment.
if that is the case we may need to read the historical logs to catch up
https://goethereumbook.org/event-read/
zelig
force-pushed
the
postage-listener
branch
from
0112f43 to
ac6b283
Compare
acud
force-pushed
the
storage-incentives
branch
2 times, most recently
from
134fa9a to
cbd4d4a
Compare
zelig
force-pushed
the
storage-incentives
branch
from
cbd4d4a to
97b2a15
Compare
acud
force-pushed
the
postage-listener
branch
from
ac6b283 to
ae024b5
Compare
|
closed in favor of #1099 |
The PR implements an event listener as per the appendix of https://hackmd.io/o8RGsNwZSN6IE0lkBAZCPw?both (#920)
this is a prerequisite of #922 and #934 (#896).