feat: vod display #686
Merged
feat: vod display #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferencsarai
approved these changes
Jan 7, 2025
|
Update: New changes now allow the user to see the preview of html5 supported media files on the download page as well. 
|
ferencsarai
approved these changes
Jan 13, 2025
|
Hello, nice PR! I have only one comment. export const META_FILE_NAME = '.swarmgatewaymeta.json'
export const PREVIEW_FILE_NAME = '.swarmgatewaypreview'IIRC, Swarm Gateway and Bee Dashboard interops to some extent with the previews. I see the This may affect the Swarm Gateway preview functionality. It would be good to clarify the role of the two products and their interoperability, and also define if Just an FYI. |
Cafe137
approved these changes
Jan 13, 2025
|
Additional refactors to make type handling more general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VOD display
Description
During file upload the user should see a preview about media related files that are html5 supported. Other files don't show any kind of preview.
Related Issues
https://solarpunk-test.atlassian.net/browse/SPDV-48
Changes Made
About the new feat
About the fix
How Has This Been Tested?
feat: I did manual tests. At the file uploader I tried out a couple of file types to see the previews.
fix: I checked the status of the uploaded files and the sync status. It should reach 100% after a certain amount of time.
Checklist
done - During file upload the user should see a preview about media related files that are html5 supported. Other files don't show any kind of preview.
done - In the Download tab, for the file preview show a video preview when the format is supported (Swarm hash > Find, or reached from the Download History).
done - Supported Image types:
'image/bmp', 'image/gif', 'image/vnd.microsoft.icon', 'image/jpeg', 'image/png', 'image/svg+xml', 'image/tiff', 'image/webp'
Screenshots (if applicable)
Preview feat:
Fix for sync:
Questions