Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make Interface.from() Full Clone #4689

Closed
wants to merge 1 commit into from
Closed

Fix: Make Interface.from() Full Clone #4689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src.ts/abi/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,12 @@ export class Interface {

// Maybe an interface from an older version, or from a symlinked copy
if (typeof((<any>value).format) === "function") {
return new Interface((<any>value).format("json"));
// format("json") implies minimal, which drops output args
// the argument can simply be removed because:
// v5: format() defaults to full: https://github.com/ethers-io/ethers.js/blob/555f16ce7bc6f5fcb40f4c88037f3e4e4182c36c/packages/abi/src.ts/interface.ts#L159
// v6: format() => !minimal => full
// alternatively, we could probe for formatJson() but that doesn't exist in v5
return new Interface((<any>value).format());
}

// Array of fragments
Expand Down