Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ENS avatar resolution using addresses #2582

Closed
wants to merge 4 commits into from
Closed

Fix ENS avatar resolution using addresses #2582

wants to merge 4 commits into from

Conversation

TomAFrench
Copy link

@TomAFrench TomAFrench commented Jan 23, 2022 •
edited
Loading

fixes #2583

@TomAFrench TomAFrench mentioned this pull request Jan 23, 2022
Closed
@ricmoo
Copy link
Member

ricmoo commented Feb 5, 2022

I'm working on #2477 (EIP-2544) which will re-write quite a bit of this; do you have any examples of an address with this configured?

@TomAFrench
Copy link
Author

TomAFrench commented Feb 5, 2022 •
edited
Loading

I'm not entirely sure what you're looking for an example of being configured but I assume you mean an address with an avatar set on its reverse record?

I don't know of any examples of setting an avatar in this way. The default reverse resolver doesn't support setting fields other than name and no frontend exists for setting other fields on the reverse record so I doubt there would be many organic examples if any.

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Feb 19, 2022
ricmoo added a commit that referenced this pull request Mar 2, 2022
@ricmoo
Add EIP-2544 Wildcard support (#2477, #2582, #2583).
83891f9
@ricmoo
Copy link
Member

ricmoo commented Mar 10, 2022

This should now be fixed in v5.6.

Try it out and let me know! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 10, 2022
@ricmoo
Copy link
Member

ricmoo commented Mar 17, 2022

This was fixed, so I'll close it. Please re-open if there are any problems.

Thanks! :)

@ricmoo ricmoo closed this Mar 17, 2022
This was referenced Apr 12, 2022
Open
Open
Open
Open
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
@ricmoo @Woodpile37
Add EIP-2544 Wildcard support (ethers-io#2477, ethers-io#2582, ethers…
817f0d6 
…-io#2583).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENS avatar resolution fails when querying using an address
2 participants
@TomAFrench @ricmoo