[Provider] Support fetching avatar metadata stored in ipfs #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #2271 |
|
Is that a valid format? I also don’t mind extending the format to include this as it doesn’t collide with other IPFS and IPNS formats, but I’m curious if there are other common formats too. |
|
Also keep in mind that ethers v5 must be ES3-compatible, so it cannot use the URL class. I’ll make the necessary changes though. |
Doesn't appear to be. https://docs.ipfs.io/how-to/address-ipfs-on-web/#native-urls It looks like all the tokens from the Nyan Cat smart contract use this format. |
ricmoo
added a commit
that referenced
this pull request
Jan 25, 2022
|
This should be fixed as of 5.5.4. Try it out and let me know if there are still any issues. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue can be reproduced by trying to fetch the avatar for "vitalik.eth"
Error:
contentScript.bundle.js:2155 Fetch API cannot load ipfs://ipfs/QmYTuHaoY1winNAxmf7JmCmSrkChuMAAnqgSuJBTiWZe9f. URL scheme "ipfs" is not supported.The image url is still not entirely correct since the current logic expects the URI to be
ipfs://{CID}but the URI returned from the metadata isipfs://ipfs/{CID}. Any suggestions on the best way to handle this?