Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random: fix browser version length check #1977

Closed
wants to merge 1 commit into from

Conversation

ChALkeR
Copy link

@ChALkeR ChALkeR commented Aug 31, 2021

E.g. new Uint8Array(NaN) creates a 0-length array, but we don't want randomBytes(NaN) to silently return a zero-length array, we want it to throw like the non-browser version does.

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label Sep 16, 2021
@ricmoo
Copy link
Member

ricmoo commented Sep 16, 2021

Agreed. I'll add this soon.

Thanks! :)

@ricmoo
Copy link
Member

ricmoo commented Oct 20, 2021

Merged.

Thanks! :)

@ricmoo ricmoo closed this Oct 20, 2021
@ricmoo
Copy link
Member

ricmoo commented Oct 20, 2021

(release in 5.5.0)

@ricmoo ricmoo added bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants